Add a log action for copy_for_translation operation #7352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaedroho
added
the
component:i18n
Manage this branch in SquashTest this branch here: https://kaedrohocopy-for-translation-l-ip5wi.squash.io |
This was referenced Jul 20, 2021
kaedroho
force-pushed
the
copy-for-translation-log
branch
from
b68123d
to
a22fb76
Compare
Currently, when a user copies a page for translation, the 'copy' log action is used. This adds a more specific 'copy_for_translation' operation to be used instead when the user is translating.
kaedroho
force-pushed
the
copy-for-translation-log
branch
from
a22fb76
to
ceb306e
Compare
gasman
approved these changes
Jul 21, 2021
gasman
reviewed
Jul 21, 2021
| @@ -71,6 +71,7 @@ Action Notes | |||
| ``wagtail.rename`` A page was renamed | |||
| ``wagtail.revert`` The page was reverted to a previous draft | |||
| ``wagtail.copy`` The page was copied to a new location | |||
| ``wagtail.copy_for_translation`` The page was copied into a new locale for translation | |||
There was a problem hiding this comment.
Just a thought... any reason not to follow the hierarchical pattern of the other action names, and make it something like wagtail.copy.for_translation?
There was a problem hiding this comment.
It seems a bit inconsistent though. For example wagtail.revert is a type of edit, and wagtail.publish.schedule is not publishing the page, just scheduling it. I like the idea of encoding the hierarchy in the names though, maybe we could fix these?
gasman
pushed a commit
that referenced
this pull request
Jul 21, 2021
Currently, when a user copies a page for translation, the 'copy' log action is used. This adds a more specific 'copy_for_translation' operation to be used instead when the user is translating.
|
Merged in bea17ac. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a user copies a page for translation, the 'copy' log action is used.
This adds a more specific 'copy_for_translation' operation to be used instead when the user is translating.