Ensure error count badge counts StreamField non-block errors #7361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes wagtail#7353 The error counter was only counting elements with class error-message, but non-block errors on ListBlock / StreamBlock use a different styling,help-critical.
Manage this branch in SquashTest this branch here: https://gasmanfixbadge-for-non-block-e-xt566.squash.io |
|
Thanks this works for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7353
The error counter was only counting elements with class error-message, but non-block errors on ListBlock / StreamBlock use a different styling, help-critical.
(For the record, I've checked that the uses of help-critical elsewhere in the codebase are also error messages, so this selector isn't being over-broad. Although hypothetically if there were any items that weren't actual error messages but warranted an "it's critically important that you read this advice" class, flagging them up via the badge is probably the right thing anyway...)