Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes the title of ModelAdmin items into links #7408

Merged
merged 2 commits into from Aug 8, 2021

Conversation

SaptakS
Copy link
Contributor

@SaptakS SaptakS commented Aug 5, 2021

Fixes #7333

As suggested by @thibaudcolas in the issue, I converted the title of the item into a link (structured it using the same HTML as page listing to maintain the same style). This allows for keyboard navigation to the action buttons for each item using the :focus-within like rest of admin.

  • For front-end changes: Did you test on all of Wagtail’s supported environments?
    • Please list the exact browser and operating system versions you tested.
      • Firefox, Chrome on Debian, safari on MacOS
    • Please list which assistive technologies you tested.
      • VoiceOver on MacOS

@squash-labs
Copy link

squash-labs bot commented Aug 5, 2021

Manage this branch in Squash

Test this branch here: https://saptaksmodeladmin-keyboard-nav-061co.squash.io

@SaptakS SaptakS marked this pull request as draft August 5, 2021 22:17
@SaptakS SaptakS force-pushed the modeladmin-keyboard-navigation branch from c12b326 to 78651a4 Compare August 5, 2021 22:52
@SaptakS SaptakS marked this pull request as ready for review August 6, 2021 07:29
Copy link
Member

@thibaudcolas thibaudcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the code only, this seems very solid. I’ll test this locally next.

SaptakS and others added 2 commits August 8, 2021 00:44
This allows for keyboard navigation to the action buttons for each
item.
@thibaudcolas thibaudcolas force-pushed the modeladmin-keyboard-navigation branch from 78651a4 to 493d8b5 Compare August 7, 2021 23:49
Copy link
Member

@thibaudcolas thibaudcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

ModelAdmin IndexView not keyboard navigable
2 participants