Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle cache_until being returned as a string in oembed responses #7427

Merged
merged 1 commit into from Aug 12, 2021
Merged

Handle cache_until being returned as a string in oembed responses #7427

merged 1 commit into from Aug 12, 2021

Conversation

gasman
Copy link
Collaborator

@gasman gasman commented Aug 11, 2021

Fixes #7415

@gasman gasman added this to the 2.14.1 milestone Aug 11, 2021
@gasman gasman requested a review from zerolab August 11, 2021 17:02
@squash-labs
Copy link

squash-labs bot commented Aug 11, 2021

Manage this branch in Squash

Test this branch here: https://gasmanfixembed-cacheuntil-stri-y8h3s.squash.io

RealOrangeOne
RealOrangeOne approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@RealOrangeOne RealOrangeOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be very rare that TypeError is raised, but shouldn't hurt catching it anyway

@gasman gasman merged commit 6f732fd into wagtail:main Aug 12, 2021
gasman added a commit that referenced this pull request Aug 12, 2021
@gasman
Release note for #7427 in 2.14.1
18918b4
gasman added a commit that referenced this pull request Aug 12, 2021
@gasman
Release note for #7427 in 2.14.1
9dc43e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerolab zerolab zerolab approved these changes

@RealOrangeOne RealOrangeOne RealOrangeOne approved these changes

Assignees
No one assigned
Labels
component:Embeds status:Needs Review type:Bug
Projects
None yet
Milestone
2.14.1
Development

Successfully merging this pull request may close these issues.

Parsing cache_until field fails on Twitter embeds
3 participants
@gasman @zerolab @RealOrangeOne