feature: Login remember me functionality #7803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://confuzeuslogin-remember-me-or5pj.squash.io |
|
Thanks @confuzeus! Just wondering if you could attach a screenshot of how this change looks? |
confuzeus
force-pushed
the
login_remember_me
branch
from
dbb5d20
to
62e0005
Compare
For sure @kaedroho :
The template code was already there but commented out. I simply uncommented it and implemented the functionality in the view. |
confuzeus
force-pushed
the
login_remember_me
branch
from
33f4d9e
to
62e0005
Compare
lb-
approved these changes
Jan 8, 2022
There was a problem hiding this comment.
@confuzeus thanks so much, this works great.
We discussed this within the core team and think this would be a great addition, approved.
Will merge in shortly (I will rebase, add changelog etc)
- Improve wagtail/admin/views/account.py - Co-authored-by: Jake Howard <RealOrangeOne@users.noreply.github.com>
lb-
added a commit
to lb-/wagtail
that referenced
this pull request
Jan 8, 2022
- relates to wagtail#7803
gasman
added a commit
that referenced
this pull request
Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users logging into the admin to specify whether they want to be remembered or not.
Instead of remembering users all the time, from now on:
Sessions expire on browser close if Remember me checkbox is unchecked.
Otherwise, they're set to expire after SESSION_COOKIE_AGE.