Fix #7884 Redirects: 'target page route' with non-RoutablePageMixin pages #7896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://ababicfix7884-redirect-page-ro-un0wu.squash.io |
ababic
force-pushed
the
fix/7884-redirect-page_route_path
branch
from
7112ef8
to
375a28b
Compare
gasman
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7884
There's no easy way to toggle fields based on chooser selection, so it makes sense for the field to be hidden for now (as per @gasman's comment).
It should no longer be possible to created an invalid redirect from within the UI, but have accounted for the
AttributeErroranyway, as there are other potential ways to bump into that (e.g. switching to a branch where the specific page type is missing)The UI should be looked at more holistically, as the issues are bigger than just this one field.