Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prettier reformatting #7912

Merged
merged 3 commits into from Feb 4, 2022
Merged

Prettier reformatting #7912

merged 3 commits into from Feb 4, 2022

Conversation

thibaudcolas
Copy link
Member

@thibaudcolas thibaudcolas commented Feb 2, 2022 •
edited

Depends on #7908. There are three additional commits in this PR:

  • The automated reformatting of existing code with Prettier.
  • Manual code changes where Prettier reformatting was causing issues (37026d5).
  • Turning on the Prettier format check in CircleCI’s frontend job.

@squash-labs
Copy link

squash-labs bot commented Feb 2, 2022

Manage this branch in Squash

Test this branch here: https://thibaudcolaschoreprettier-form-i6flq.squash.io

@thibaudcolas thibaudcolas added this to In Progress in UI team via automation Feb 2, 2022
@thibaudcolas thibaudcolas added this to the 2.17 milestone Feb 2, 2022
@thibaudcolas thibaudcolas mentioned this pull request Feb 2, 2022
Merged
3 tasks
@thibaudcolas thibaudcolas marked this pull request as ready for review February 2, 2022 16:13
@thibaudcolas thibaudcolas changed the title WIP: Prettier reformatting Prettier reformatting Feb 2, 2022
@thibaudcolas thibaudcolas linked an issue Feb 2, 2022 that may be closed by this pull request
Automatic code formatting with Prettier #6059
Closed
@thibaudcolas thibaudcolas self-assigned this Feb 4, 2022
@thibaudcolas thibaudcolas merged commit af942a2 into wagtail:main Feb 4, 2022
UI team automation moved this from In Progress to Done Feb 4, 2022
@thibaudcolas thibaudcolas deleted the chore/prettier-formatting branch February 4, 2022 11:57
@thibaudcolas thibaudcolas mentioned this pull request Feb 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thibaudcolas thibaudcolas

Labels
type:Cleanup/Optimisation
Projects
UI team
Status: Done
Page editor 2022
Status: Done
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

Automatic code formatting with Prettier
1 participant
@thibaudcolas