New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the Hallo Editor - now provided as an external package #7922
Conversation
Manage this branch in SquashTest this branch here: https://lb-featurehallo-editor-removal-fp9zn.squash.io |
@lb- looks like it’s all passing :) I won’t be able to review this this week but should be able to help from next week onwards. |
2502d31
to
e224f79
Compare
fe8b7f8
to
c268b47
Compare
208cb4b
to
a48e704
Compare
@thibaudcolas ready for a review now |
a48e704
to
f9093b3
Compare
rebased on main & fixed up the conflicts with the black formatter change |
f9093b3
to
fd64207
Compare
6a890e7
to
295289a
Compare
Reminder to self - rebase needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking excellent @lb-. I’ve picked up very minor things. I think they’re worth fixing but should be very straightforward and this will be good to merge afterwards. This is as thorough of a cleanup as I’ve ever seen!
I have yet to try the wagtail-hallo package, will get to it next, considering the feedback on #6228 I think we can merge this already and if anything further comes up we can pick it up in wagtail-hallo.
4bbf31c
to
51a519e
Compare
@thibaudcolas thanks, I did my best to get the draftail.js to be consistently Draftail as part of this - some comments have been moved to pydoc style module descriptions instead as that seemed more appropriate. Can you take another look please, I am happy to merge in but just wanted to get another pass. Thanks heaps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
51a519e
to
7d425f4
Compare
How to test this
wagtail/admin/static
and then run the Wagtail build pipelinenvm use
thennpm run build
- this is required so that validation can be done without the styles/JS provided by Wagtail and only the ones provided by the new package.