Redirect to page edit view when submitting for a single locale #7941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an editor decides to submit a page for translation and only chooses one locale, they are redirected to the new translated page's edit view.
Manage this branch in SquashTest this branch here: https://mixxorzpost-submit-translation-dkvnh.squash.io |
zerolab
approved these changes
Feb 9, 2022
zerolab
added
the
component:i18n
|
One check was unsuccessful. Seems to be the one running against TODO:
|
|
@mixxorz yes, the failing tests against Django main come from taggit as far as I can tell. This is an expected failure, it is just that GitHub Actions has no good way of indicating that yet We update the changelog after merge, so nothing to worry about there |
|
@mixxorz great work, thanks for putting this together and also for the robust tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an editor decides to submit a page for translation and only chooses one locale, they are redirected to the new translated page's edit view. This behaviour is the same for snippets.
The behaviour is unchanged when translating pages/snippets to multiple locales.
This is the
simple_translationscounterpart to this change on wagtail-localize: wagtail/wagtail-localize#518