Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new version fo Wagtail Space docs banner. Fix #6089 #7956

Merged
merged 2 commits into from Feb 11, 2022
Merged

Add new version fo Wagtail Space docs banner. Fix #6089 #7956

merged 2 commits into from Feb 11, 2022

Conversation

thibaudcolas
Copy link
Member

@thibaudcolas thibaudcolas commented Feb 10, 2022 •
edited

Live demo. To promote https://us.wagtail.space/. Updated version from what was implemented for #4986. Technically addresses #6089, although I suspect this wasn’t intended for 2022!

wagtail-space-banner

This is the same design, with a new cut-off date, content updates, and accessibility fixes. Tested briefly in macOS Chrome, Safari, Firefox. Also it looks like our theme’s add_css_file loading is broken.

@thibaudcolas thibaudcolas added this to the 2.16.1 milestone Feb 10, 2022
@squash-labs
Copy link

squash-labs bot commented Feb 10, 2022

Manage this branch in Squash

Test this branch here: https://thibaudcolaschorewagtail-space-h3ez0.squash.io

gasman
gasman reviewed Feb 11, 2022
View reviewed changes
docs/_static/js/banner.js Outdated Show resolved Hide resolved
@gasman gasman merged commit 0466851 into wagtail:main Feb 11, 2022
gasman added a commit that referenced this pull request Feb 11, 2022
@thibaudcolas @gasman
Add new version fo Wagtail Space docs banner. Fix #6089 (#7956)
36ef082 
* Add new version fo Wagtail Space docs banner. Fix #6089

* Fix closing date

Co-authored-by: Matt Westcott <matthew@torchbox.com>
@zerolab
Copy link
Contributor

zerolab commented Feb 11, 2022 •
edited

I believe this introduced a weird logo wiggle see https://docs.wagtail.org/en/stable/ vs https://docs.wagtail.org/en/v2.16/ -- hover on "[logo] Wagtail Documentation" in the header 🙈

@thibaudcolas thibaudcolas deleted the chore/wagtail-space-us-banner branch February 11, 2022 14:23
@zerolab zerolab mentioned this pull request Feb 15, 2022
Closed
thibaudcolas added a commit to thibaudcolas/wagtail that referenced this pull request Feb 15, 2022
@thibaudcolas
Remove all style customisations for documentation, except banner. Fix w…
a835a4b 
…agtail#7987

All of those customisations predate wagtail#7956, which fixed the loading of the CSS, so they were likely only intended for our previous Sphinx theme.
@thibaudcolas thibaudcolas mentioned this pull request Feb 15, 2022
Merged
gasman pushed a commit that referenced this pull request Feb 18, 2022
@thibaudcolas
Remove all style customisations for documentation, except banner. Fix #…
0b37f6d 
…7987 (#7990)

All of those customisations predate #7956, which fixed the loading of the CSS, so they were likely only intended for our previous Sphinx theme.
gasman pushed a commit that referenced this pull request Feb 18, 2022
@thibaudcolas @gasman
Remove all style customisations for documentation, except banner. Fix #…
88ad19a 
…7987 (#7990)

All of those customisations predate #7956, which fixed the loading of the CSS, so they were likely only intended for our previous Sphinx theme.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gasman gasman gasman left review comments

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
2.16.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thibaudcolas @zerolab @gasman