Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync tree: cascade unpublish, move and delete #7984

Merged
merged 9 commits into from
Apr 17, 2022
Merged

Sync tree: cascade unpublish, move and delete #7984

merged 9 commits into from
Apr 17, 2022

Conversation

zerolab
Copy link
Contributor

@zerolab zerolab commented Feb 14, 2022 •
edited

This PR fixes #7592. It:

  • adds a hook
  • uses it in
    • single unpublish view
    • single delete view
    • single move view
  • adds tests

⚠️ bulk actions will be tackled separately

@zerolab zerolab marked this pull request as draft February 14, 2022 17:10
@squash-labs
Copy link

squash-labs bot commented Feb 14, 2022

Manage this branch in Squash

Test this branch here: https://featuresync-tree-unpublish-cas-ls1vx.squash.io

@zerolab zerolab changed the title Ssync tree: unpublish cascade Sync tree: unpublish cascade Feb 14, 2022
@zerolab zerolab force-pushed the feature/sync-tree-unpublish-cascade branch from 039fa7e to e933187 Compare February 14, 2022 17:26
@zerolab zerolab force-pushed the feature/sync-tree-unpublish-cascade branch from e933187 to 3c08275 Compare February 23, 2022 16:45
This was referenced Feb 23, 2022
Closed
Closed
@KalobTaulien KalobTaulien mentioned this pull request Mar 9, 2022
Closed
@zerolab zerolab marked this pull request as ready for review March 9, 2022 21:39
@zerolab zerolab force-pushed the feature/sync-tree-unpublish-cascade branch 2 times, most recently from 9fd2e81 to ce78949 Compare March 25, 2022 11:06
@zerolab zerolab changed the title Sync tree: unpublish cascade Sync tree: cascade unpublish, move and delete Mar 25, 2022
@zerolab zerolab requested a review from kaedroho March 25, 2022 11:08
KalobTaulien
KalobTaulien approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@KalobTaulien KalobTaulien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely need someone else to review this since I did a bunch of work on this PR. But the initial hook seems to work exactly as expected, and the docs make sense imo.

@zerolab zerolab force-pushed the feature/sync-tree-unpublish-cascade branch 2 times, most recently from ee80933 to 1353d3d Compare April 4, 2022 20:52
This was referenced Apr 11, 2022
Closed
Draft
kaedroho
kaedroho suggested changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@kaedroho kaedroho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a very nitpicky comment about wording and a comment about the naming of the hook.

The rest of the implementation all looks good to me! Nice work!

wagtail/admin/templates/wagtailadmin/pages/confirm_move.html Outdated Show resolved Hide resolved
docs/reference/hooks.rst Outdated Show resolved Hide resolved
zerolab and others added 6 commits April 14, 2022 13:58
@zerolab
Add construct_synced_page_tree_list hook and use in page unpublish view
41e3b1f
@zerolab
Implement construct_synced_page_tree_list in simple_translation
18d5613 
but only when sync page tree is enabled
@zerolab
Add hook documentation
7fab3dd
@KalobTaulien @zerolab
Add construct_synced_page_tree_list hook tests (#8058)
ea1fc65
@zerolab @KalobTaulien
Move translated and alias pages when WAGTAIL_I18N_ENABLED and WAGTAIL…
f31cf2c 
…SIMPLETRANSLATION_SYNC_PAGE_TREE are enabled

Co-Authored-By: Kalob Taulien <4743971+KalobTaulien@users.noreply.github.com>
@zerolab @KalobTaulien
Delete corresponding translations when WAGTAIL_I18N_ENABLED and WAGTA…
dfa41c9 
…ILSIMPLETRANSLATION_SYNC_PAGE_TREE are true

Co-Authored-By: Kalob Taulien <4743971+KalobTaulien@users.noreply.github.com>
@zerolab zerolab force-pushed the feature/sync-tree-unpublish-cascade branch from 1353d3d to 21494a5 Compare April 14, 2022 16:05
@zerolab zerolab force-pushed the feature/sync-tree-unpublish-cascade branch from 21494a5 to ac292e4 Compare April 14, 2022 16:12
@zerolab zerolab requested a review from kaedroho April 14, 2022 16:15
@kaedroho kaedroho merged commit 4cc1032 into main Apr 17, 2022
@kaedroho kaedroho deleted the feature/sync-tree-unpublish-cascade branch April 17, 2022 16:34
@zerolab zerolab mentioned this pull request Apr 20, 2022
Open
@zerolab zerolab added this to the 4.0 milestone May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaedroho kaedroho kaedroho approved these changes

@KalobTaulien KalobTaulien KalobTaulien approved these changes

Assignees
No one assigned
Labels
component:Page
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Unpublish / Delete / Move a page should optionally cascade to other locales
4 participants
@zerolab @kaedroho @KalobTaulien @lb-