Tailwind package setup #8003
Merged
Tailwind package setup #8003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://stevedyatailwind-setup-3dr5r.squash.io |
thibaudcolas
requested changes
Feb 16, 2022
Merged
thibaudcolas
requested changes
Feb 22, 2022
There was a problem hiding this comment.
@stevedya there are two big things I don’t see here and we’ll need to make a plan for, either in this PR or out:
- How the Tailwind theme interacts with Sass – do we generate variables, use the built-in theme, or a custom version of that
- How we do logical properties in CSS (we’ll completely disallow this in stylesheets, so ideally would want the same restriction in utility classes).
Additionally for this PR:
- I think you should change at least one template to use Tailwind utility classes. I’d recommend the styleguide’s
base.html - I would like us to remove some of Wagtail’s existing utilities if they have clear Tailwind equivalents where there would be no possible backwards compat issues (
u-text-weight-normal,u-text-transform-uppercase,u-hiddenseem like clear candidates. Perhapsvisuallyhidden).
Co-authored-by: Thibaud Colas <thibaudcolas@gmail.com>
Co-authored-by: Thibaud Colas <thibaudcolas@gmail.com>
thibaudcolas
force-pushed
the
tailwind-setup
branch
from
1b0e426
to
d3ed227
Compare
thibaudcolas
approved these changes
Feb 27, 2022
There was a problem hiding this comment.
Thank you @stevedya! I had to re-add the design tokens integration to make sure this was working, and swapped to Tailwind classes in two templates. Nice one!
For the other things I had mentioned, I’ll create follow-up tickets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #7981. This is a basic setup of tailwind css to generate utility styles. We may want to merge along with #7978 in order to have the tailwind configuration appropriately configured for wagtail's design system.