Set the filename in Content-Disposition for inline files #8010
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2.11, the sendfile util was changed to serve PDFs inline. In the process, this prevented the filename from being set so when users go to save the PDF, the filename would be blank in the save dialog. This PR always sends the
filename
in the "Content-Disposition" header whether the file is served as inline or attachment so the save dialog will have a sensible default value.