Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update browserslist - not ie 11 #8041

Merged
merged 1 commit into from Mar 2, 2022
Merged

update browserslist - not ie 11 #8041

merged 1 commit into from Mar 2, 2022

Conversation

lb-
Copy link
Member

@lb- lb- commented Feb 24, 2022

  • Update browserslist configuration to explicitly include not ie 11 to align with our documentation and current development support
  • Note that this does not actually get used for the JS bundle generation (that gets declared at tsconfig) so this change should not adjust the existing JS build
  • Tested on Firefox 97, Chrome 100, Safari 15 on macOS
  • Also - the wagtail name removal in package lock is just the result of running npm install

@squash-labs
Copy link

squash-labs bot commented Feb 24, 2022

Manage this branch in Squash

Test this branch here: https://lb-featurebrowserslist-not-ie-whxfx.squash.io

allcaps
allcaps approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@allcaps allcaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lb- lb- merged commit dc8fdeb into wagtail:main Mar 2, 2022
@lb- lb- deleted the feature/browserslist-not-ie-11 branch May 12, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thijskramer thijskramer thijskramer approved these changes

@allcaps allcaps allcaps approved these changes

Assignees
No one assigned
Labels
type:Cleanup/Optimisation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lb- @thijskramer @allcaps