Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed redundant text-transform instances #8129

Merged
merged 2 commits into from Mar 21, 2022
Merged

Removed redundant text-transform instances #8129

merged 2 commits into from Mar 21, 2022

Conversation

PaarthAgarwal
Copy link
Member

@PaarthAgarwal PaarthAgarwal commented Mar 15, 2022 •
edited

This PR fixes "Refactor Code" and "Configure Tailwind" part of #8121.

  • I have removed all redundant text-transform instances from the stylesheets.
  • Disabled the text-transform Tailwind plugin.

@squash-labs
Copy link

squash-labs bot commented Mar 15, 2022

Manage this branch in Squash

Test this branch here: https://paarthagarwalcleanup-styleshee-m8wta.squash.io

@thibaudcolas thibaudcolas added the GSOC Google Summer of Code label Mar 16, 2022
@PaarthAgarwal PaarthAgarwal mentioned this pull request Mar 16, 2022
Merged
@thibaudcolas thibaudcolas self-requested a review March 16, 2022 11:29
@lb- lb- mentioned this pull request Mar 16, 2022
Closed
lb-
lb- requested changes Mar 18, 2022
View reviewed changes
Copy link
Member

@lb- lb- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is one minor typo, looks good otherwise.

wagtail/admin/static_src/wagtailadmin/css/normalize.css Outdated Show resolved Hide resolved
@PaarthAgarwal
Copy link
Member Author

I have fixed the typo as mentioned.

@PaarthAgarwal
Copy link
Member Author

@lb- have a look

@lb- lb- self-requested a review March 21, 2022 21:44
lb-
lb- approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@lb- lb- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking great @PaarthAgarwal thank you!

@lb- lb- merged commit 91970e6 into wagtail:main Mar 21, 2022
@lb-
Copy link
Member

lb- commented Mar 21, 2022

Did not add this to changelog as already included in there (related to text transform)

@thibaudcolas thibaudcolas added this to the 2.17 milestone Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lb- lb- lb- approved these changes

@thibaudcolas thibaudcolas Awaiting requested review from thibaudcolas

Assignees
No one assigned
Labels
component:Design system Including the pattern library (Storybook) GSOC Google Summer of Code type:Cleanup/Optimisation
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PaarthAgarwal @lb- @thibaudcolas