Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put PR template boilerplate in HTML comment #8224

Merged
merged 1 commit into from Mar 27, 2022

Conversation

gasman
Copy link
Collaborator

@gasman gasman commented Mar 26, 2022

Follow-up to #8219 - put boilerplate in HTML comment so that users don't have to be told to remove it.

Please check the following:

  • Do the tests still pass?1
  • Does the code comply with the style guide?
    • Run make lint from the Wagtail root.
  • For Python changes: Have you added tests to cover the new/fixed behaviour?
  • For front-end changes: Did you test on all of Wagtail’s supported environments?2
    • Please list the exact browser and operating system versions you tested:
    • Please list which assistive technologies 3 you tested:
  • For new features: Has the documentation been updated accordingly?

Please describe additional details for testing this change.

Footnotes

  1. Development Testing

  2. Browser and device support

  3. Accessibility Target

@squash-labs
Copy link

squash-labs bot commented Mar 26, 2022

Manage this branch in Squash

Test this branch here: https://gasmanadminpr-template-comment-m5z00.squash.io

@lb- lb- merged commit 5c6f12a into wagtail:main Mar 27, 2022
@lb- lb- added Infrastructure Issues that relate to online tools we use to develop Wagtail and removed status:Needs Review labels Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues that relate to online tools we use to develop Wagtail sprint:Cleveland2022 type:Cleanup/Optimisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants