Switch locales selector JS error #8468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://stevedyachore8466-switch-local-909va.squash.io |
lb-
added
status:Needs Review
component:i18n
thibaudcolas
pushed a commit
that referenced
this pull request
May 6, 2022
stevedya
added a commit
to stevedya/wagtail
that referenced
this pull request
May 18, 2022
…gtail#8462 * Check for hover tool tip instance to avoid throwing errors * Remove multiple attr because it is un-needed now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8466. Error caused by tippy trying to disable a hoverTooltipInstance that doesn't exist.
Fix applied
-Wrapped hoverTooltipInstance inside of an if statement to ensure it exists before trying to call
disableorenable. This is needed as hover-tooltip-content is an optional attribute which turns this feature on and off.-Removed
multiple: trueon tippy instances as it is not needed anymore. This addresses #8462 as well.Extra Info about this: Since we are using two instances of tippy on the same element for the actions toggle specifically, using the multiple: true attribute allowed us to have multiple instances of tippy for the same element. However in tippy v5 and v6 is they've changed it so as long as you reference the same element it will init multiple for the same tippy instance. Tippy migration notes