Disable webpack css url rewriting #8518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://jacobtoppmfixdisable-webpack-c-48z49.squash.io |
lb-
approved these changes
May 11, 2022
There was a problem hiding this comment.
Works great, did a bit of research and this make sense.
https://webpack.js.org/loaders/css-loader/#url
Before
After
This was causing relative urls to be rewritten to use the publicPath. This meant that the icon font would be referenced at the wrong location if sites had changed STATIC_URL fixes wagtail#8517
lb-
force-pushed
the
fix/disable-webpack-css-url-rewriting
branch
from
17b657f
to
0664e0d
Compare
lb-
pushed a commit
that referenced
this pull request
May 11, 2022
This was causing relative urls to be rewritten to use the publicPath. This meant that the icon font would be referenced at the wrong location if sites had changed STATIC_URL fixes #8517
|
Cherry picked into 3.0 9b659cb |
|
Thanks @lb- ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing relative urls to be rewritten to use the
publicPathin the webpack config,/static/.This meant that the icon font would be referenced at the wrong location if sites had changed STATIC_URL
Fixes #8517