Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopted shared header for form submission page #8857

Closed

Conversation

PaarthAgarwal
Copy link
Member

Addresses #8539.
I have adopted shared header template for form submissions page.
As discussed with @lb- I have shifted form rows to the bottom of header.
Before:

Screenshot from 2022-07-15 09-54-08

Screenshot from 2022-07-15 09-54-40

Screenshot from 2022-07-15 09-54-58

Screenshot from 2022-07-15 09-55-18

After:

Screenshot from 2022-07-15 09-48-20

Screenshot from 2022-07-15 09-52-53

Screenshot from 2022-07-15 09-53-16

Screenshot from 2022-07-15 09-53-40

@squash-labs
Copy link

squash-labs bot commented Jul 15, 2022

Manage this branch in Squash

Test this branch here: https://paarthagarwalform-submissions-bupzb.squash.io

@thibaudcolas thibaudcolas added type:Enhancement component:Design system Including the pattern library (Storybook) GSOC Google Summer of Code labels Jul 15, 2022
@thibaudcolas thibaudcolas added this to the 4.0 milestone Jul 15, 2022
@lb-
Copy link
Member

lb- commented Jul 17, 2022

I think maybe we can put the date fields outside the header completely.
Also the fields need to have the left / right margin removed so the content is all aligned to the side.

@lb-
Copy link
Member

lb- commented Jul 18, 2022

As discussed

  • Let's try to bring the date fields back into the header fully (where they were before roughly) - it seems like this will be the path of least resistance
  • Add a new way to add search_fields to the shared header template that also allows us to avoid passing in a search_url (as this form just submits to the view itself).
  • Tweak the classes first to get pretty close and if needed add some custom CSS but see how you go by looking at the classes / layout of other headers first.

@lb-
Copy link
Member

lb- commented Jul 18, 2022

Closing in favour of #8862

@lb- lb- closed this Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:Design system Including the pattern library (Storybook) GSOC Google Summer of Code type:Enhancement
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants