Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded float styles on 404 page #8914

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

fabienheureux
Copy link
Member

@fabienheureux fabienheureux commented Jul 28, 2022

Following #8126

  • 404 page
  • page editor
  • account page
  • report page
  • login page
  • styleguide
  • no search results img
  • choose parent page

Please check the following:

  • Do the tests still pass?1
  • Does the code comply with the style guide?
    • Run make lint from the Wagtail root.
  • For Python changes: Have you added tests to cover the new/fixed behaviour?
  • For front-end changes: Did you test on all of Wagtail’s supported environments?2
    • Please list the exact browser and operating system versions you tested:
    • Please list which assistive technologies 3 you tested:
  • For new features: Has the documentation been updated accordingly?

Please describe additional details for testing this change.

Footnotes

  1. Development Testing

  2. Browser and device support

  3. Accessibility Target

@squash-labs
Copy link

squash-labs bot commented Jul 28, 2022

Manage this branch in Squash

Test this branch here: https://fabienheureux8126-remove-float-ljcbq.squash.io

@thibaudcolas thibaudcolas marked this pull request as ready for review February 17, 2023 00:01
@thibaudcolas thibaudcolas added type:Cleanup/Optimisation component:i18n i18n for content created in Wagtail, not the admin UI itself labels Feb 17, 2023
@thibaudcolas thibaudcolas added this to the 5.0 milestone Feb 17, 2023
Copy link
Member

@thibaudcolas thibaudcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fabienheureux! I see this has stalled so I’ve taken the liberty to un-draft the PR and I’ll merge the current changes, which are good as-is.

@thibaudcolas thibaudcolas changed the title Remove float usage Remove unneeded float styles on 404 page Feb 17, 2023
@thibaudcolas thibaudcolas merged commit 065df60 into wagtail:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:i18n i18n for content created in Wagtail, not the admin UI itself type:Cleanup/Optimisation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants