Ensure all icon template tags use classname instead of class_name & add deprecation warning
#9770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://lb-feature6107-ensure-icon-tem-cgwnh.squash.io |
This was referenced Dec 9, 2022
lb-
force-pushed
the
feature/6107-ensure-icon-template-tag-uses-classname-with-warning
branch
from
67b6788
to
dd97faa
Compare
- If using `class_name` we will now trigger a warning that this will be removed in Wagtail 5.0 - Update release notes accordingly
lb-
force-pushed
the
feature/6107-ensure-icon-template-tag-uses-classname-with-warning
branch
from
dd97faa
to
1428705
Compare
gasman
approved these changes
Jan 19, 2023
|
Merged in 899730d |
lb-
deleted the
feature/6107-ensure-icon-template-tag-uses-classname-with-warning
branch
|
Thanks Matt. |
lb-
commented
Jan 31, 2023
lb-
added a commit
to lb-/wagtail
that referenced
this pull request
Feb 1, 2023
lb-
added a commit
to lb-/wagtail
that referenced
this pull request
Sep 15, 2023
…ar usage - https://docs.wagtail.org/en/stable/contributing/general_guidelines.html#use-classname-in-python-html-template-tag-variables - Adds a deprecation path, including documentation to further remove unpredictable naming of adding `classname` in Python APIs - Intentionally keeps `classNames` in Telepath adaptor inner usage as this convention is not set, however, the server side value passed in will use `classname` - See wagtail#9769 & wagtail#9770
lb-
added a commit
to lb-/wagtail
that referenced
this pull request
Sep 17, 2023
- Adds a deprecation path, including documentation to further remove unpredictable naming of adding `classname` in Python APIs - Intentionally keeps `classNames` in Telepath adaptor inner usage as this convention is not set, however, the server side value passed in will use `classname` - See https://docs.wagtail.org/en/stable/contributing/general_guidelines.html#use-classname-in-python-html-template-tag-variables - See wagtail#9769 & wagtail#9770
5 tasks
lb-
added a commit
to lb-/wagtail
that referenced
this pull request
Sep 25, 2023
- Adds a deprecation path, including documentation to further remove unpredictable naming of adding `classname` in Python APIs - Intentionally keeps `classNames` in Telepath adaptor inner usage as this convention is not set, however, the server side value passed in will use `classname` - See https://docs.wagtail.org/en/stable/contributing/general_guidelines.html#use-classname-in-python-html-template-tag-variables - See wagtail#9769 & wagtail#9770
lb-
added a commit
to lb-/wagtail
that referenced
this pull request
Oct 2, 2023
- Adds a deprecation path, including documentation to further remove unpredictable naming of adding `classname` in Python APIs - Intentionally keeps `classNames` in Telepath adaptor inner usage as this convention is not set, however, the server side value passed in will use `classname` - See https://docs.wagtail.org/en/stable/contributing/general_guidelines.html#use-classname-in-python-html-template-tag-variables - See wagtail#9769 & wagtail#9770
lb-
added a commit
to lb-/wagtail
that referenced
this pull request
Oct 2, 2023
- Adds a deprecation path, including documentation to further remove unpredictable naming of adding `classname` in Python APIs - Intentionally keeps `classNames` in Telepath adaptor inner usage as this convention is not set, however, the server side value passed in will use `classname` - See https://docs.wagtail.org/en/stable/contributing/general_guidelines.html#use-classname-in-python-html-template-tag-variables - See wagtail#9769 & wagtail#9770
lb-
added a commit
to lb-/wagtail
that referenced
this pull request
Oct 2, 2023
- Adds a deprecation path, including documentation to further remove unpredictable naming of adding `classname` in Python APIs - Intentionally keeps `classNames` in Telepath adaptor inner usage as this convention is not set, however, the server side value passed in will use `classname` - See https://docs.wagtail.org/en/stable/contributing/general_guidelines.html#use-classname-in-python-html-template-tag-variables - See wagtail#9769 & wagtail#9770
lb-
added a commit
to lb-/wagtail
that referenced
this pull request
Oct 2, 2023
- Adds a deprecation path, including documentation to further remove unpredictable naming of adding `classname` in Python APIs - Intentionally keeps `classNames` in Telepath adaptor inner usage as this convention is not set, however, the server side value passed in will use `classname` - See https://docs.wagtail.org/en/stable/contributing/general_guidelines.html#use-classname-in-python-html-template-tag-variables - See wagtail#9769 & wagtail#9770
lb-
added a commit
to lb-/wagtail
that referenced
this pull request
Oct 3, 2023
- Adds a deprecation path, including documentation to further remove unpredictable naming of adding `classname` in Python APIs - Intentionally keeps `classNames` in Telepath adaptor inner usage as this convention is not set, however, the server side value passed in will use `classname` - See https://docs.wagtail.org/en/stable/contributing/general_guidelines.html#use-classname-in-python-html-template-tag-variables - See wagtail#9769 & wagtail#9770
lb-
added a commit
that referenced
this pull request
Oct 3, 2023
- Adds a deprecation path, including documentation to further remove unpredictable naming of adding `classname` in Python APIs - Intentionally keeps `classNames` in Telepath adaptor inner usage as this convention is not set, however, the server side value passed in will use `classname` - See https://docs.wagtail.org/en/stable/contributing/general_guidelines.html#use-classname-in-python-html-template-tag-variables - See #9769 & #9770
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #9769 and updates all
{% icon ...template tag usage toclassnameinstead ofclass_name. It also adds a deprecation warning & upgrade considerations to move away from using the previous approach.To validate
Within Bakerydemo, or even Wagtail admin code, change an icon template usage to use
class_name='...'and you should see something like the following warning in the console.Checklist