converted initSkipLink to Stimulus and wrote tests for it #9818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://lovelyfin00skip-link-stimulus-n63t7.squash.io |
|
Looks like the CI has flagged that your HTML is not formatted - |
lb-
requested changes
Dec 22, 2022
lb-
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
@Lovelyfin00 this works great!
I have a few changes suggested, which I have made and will push up to your branch, however please read through in detail to understand the changes.
I will check the CI runs and merge in.
I have also added a commit on this branch which just renames the files before adding your changes - I can explain this on our call but please remind me to explain why we do this.
| Main content | ||
| </main> | ||
| <button id="other-content">other</button> | ||
| `; |
There was a problem hiding this comment.
Not a huge problem but we do not need to indent this test HTML so much, also the main/main can be in one line.
This just makes it more readable.
This is not easily compatible with code that initialises properties outside of the constructor (used in Stimulus)
lb-
force-pushed
the
skip-link-stimulus
branch
from
2e19226
to
cd96de2
Compare
lb-
reviewed
Jan 11, 2023
lb-
pushed a commit
to thibaudcolas/wagtail
that referenced
this pull request
Jan 26, 2023
- Use declare for existing Stimulus controllers - First enabled in wagtail#9761 & then disabled in wagtail#9818
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9810
Fix Summary
After the Skip button has been clicked