Issue #101: Draft for precision-based calculator #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ze() method very compact & also give us chance to introduce a new way of calculation, precision-based calculation. By this we can have a non-breaking change since that it's optional to choose between the default (old) calculator & the precision-based (new) calculator. Also It'll be open for everyone to have his own calculation if there's a special need.
Duplicated DateHumanizeTests, as PrecisionBasedDistanceOfTimeTests, to examine compatibility with previous calculation method. Minor refactor: replaced Dotiw by DistanceOfTime in namespaces & types.
|
Accidentally created pull request against forked repository (origin) instead of the original one (upstream) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an interesting issue. The point what makes me don't feel free while implementing this is the static extension method Humanize(). I understand its value but I think it has side effects. Sure, this is not final but I'll stop until I get your feedback.
Note: There's a proposal to how to unify DateHumanize() & TimeSpanHumanize() in DefaultFormatter. Tell me what do you think.