Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure while fetching WebIcon #10

Closed
mark-kowalski opened this issue Apr 3, 2018 · 1 comment
Closed

Failure while fetching WebIcon #10

mark-kowalski opened this issue Apr 3, 2018 · 1 comment
Labels

Comments

@mark-kowalski
Copy link

I am getting a error when the module tries to fetch the WebIcon of my app. Easy solution would be to check if variable webpIcon is not null. Are you willing to fix this or should i create a PullRequest for that?

TypeError: Cannot read property 'startsWith' of undefined
    at Request._callback (/Users/kowalma/repo/dev-ops/reviewBot/node_modules/reviews-to-slack/index.js:150:21)
    at Request.self.callback (/Users/kowalma/repo/dev-ops/reviewBot/node_modules/reviews-to-slack/node_modules/request/request.js:186:22)
    at Request.emit (events.js:180:13)
    at Request.<anonymous> (/Users/kowalma/repo/dev-ops/reviewBot/node_modules/reviews-to-slack/node_modules/request/request.js:1163:10)
    at Request.emit (events.js:180:13)
    at IncomingMessage.<anonymous> (/Users/kowalma/repo/dev-ops/reviewBot/node_modules/reviews-to-slack/node_modules/request/request.js:1085:12)
    at Object.onceWrapper (events.js:272:13)
    at IncomingMessage.emit (events.js:185:15)
    at endReadableNT (_stream_readable.js:1101:12)
    at process._tickCallback (internal/process/next_tick.js:114:19)
reviews-to-slack/index.js:150
      if (!webpIcon.startsWith('http')) {
                    ^
@wahni
Copy link
Owner

wahni commented Apr 3, 2018

@mark-kowalski Thanks for reporting. It looks like the Google Play app page structure was changed, neither id-app-title or cover-image classes are defined anymore. I can have a fix up in a few hours. Will also make it handle missing elements more gracefully..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants