Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find specific error for sign up and login error #134

Closed
Braden50 opened this issue May 17, 2021 · 1 comment · Fixed by #145
Closed

Find specific error for sign up and login error #134

Braden50 opened this issue May 17, 2021 · 1 comment · Fixed by #145
Assignees
@Braden50
Labels
1 hour

Comments

@Braden50
Copy link
Collaborator

Currently, we have a try-catch block in the backend that catches any error from a get request and assumes that if an error is caught then the user doesn't exist. This is bad code because we want full accuracy of whether or not a user is in our system.

To Solve: refactor the code such that the response checks for the specific error in some way
@Braden50 Braden50 self-assigned this May 24, 2021
@Braden50 Braden50 mentioned this issue May 26, 2021
Merged
@Braden50
Copy link
Collaborator Author

Actual time ~1 hour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Braden50 Braden50

Labels
1 hour
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Braden50/more specific error catch Waidhoferj/CSC-308-309-Project
1 participant
@Braden50