Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection of MeasureCollections in EvaluateClustering not enabled #113

Closed
richard-moulton opened this issue Sep 22, 2017 · 1 comment
Closed

Comments

@richard-moulton
Copy link
Contributor

The measureCollectionType option in the EvaluateClustering task (line 46) purports to allow the user to select which measures they want to use in evaluating their learner's performance. This, however, is not properly implemented.

The BatchCmd getMeasureSelection method (line 88) takes an integer argument specifying the measure collections to select, but then adds the same measure collections regardless of argument. These are EntropyCollection, F1, General, SSQ, SilhouetteCoefficient and StatisticalCollection.

Additionally, when the MeasureCollection returned by BatchCmd getMeasureSelection is passed to the BatchCmd getMeasures method (line 202) there is no check of whether the measures are enabled - instead the measure collection's default enabled values are used. This makes it impossible to add measure collections whose default enabled value(s) is (are) false.

@richard-moulton
Copy link
Contributor Author

Pull request #115 was accepted and merged; the issue has been addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant