[V2] Mac: Cannot show menus correctly

[cxt90730]

Description

Cannot show menus correctly on mac. Location and label display is not what I expect. I don't know if the document needs to be updated? (e.g. runtime.Quit now needs ctx of lifecycle, but document of Menus do not show this.)

To Reproduce

Mycode:

        AppMenu := menu.NewMenu()
	FileMenu := AppMenu.AddSubmenu("File")
	FileMenu.AddText("WindowSetTitle", keys.CmdOrCtrl("1"), func(_ *menu.CallbackData) {
		runtime.WindowSetTitle(ctx, time.Now().Local().String())
	})
	FileMenu.AddSeparator()
	FileMenu.AddText("WindowCenter", keys.CmdOrCtrl("2"), func(_ *menu.CallbackData) {
		runtime.WindowCenter(ctx)
	})
	FileMenu.AddSeparator()
	FileMenu.AddText("WindowSetLightTheme", keys.CmdOrCtrl("3"), func(_ *menu.CallbackData) {
		runtime.WindowSetLightTheme(ctx)
	})
	FileMenu.AddText("WindowSetDarkTheme", keys.CmdOrCtrl("4"), func(_ *menu.CallbackData) {
		runtime.WindowSetDarkTheme(ctx)
	})
	FileMenu.AddSeparator()
	FileMenu.AddText("WindowGetSize", keys.CmdOrCtrl("5"), func(_ *menu.CallbackData) {
		fmt.Println(runtime.WindowGetSize(ctx))
	})
	if os_runtime.GOOS == "darwin" {
		AppMenu.Append(menu.AppMenu())
		AppMenu.Append(menu.EditMenu()) // on macos platform, we should append EditMenu to enable Cmd+C,Cmd+V,Cmd+Z... shortcut
	}
	runtime.MenuSetApplicationMenu(ctx, AppMenu)

Expected behaviour

display correct

Screenshots

No response

Attempted Fixes

No response

System Details

unnecessary...

Additional context

No response

[cxt90730]

[cxt90730]

emmm, I need to add these code before:

         AppMenu := menu.NewMenu()
	if os_runtime.GOOS == "darwin" {
		AppMenu.Append(menu.AppMenu())
	}

because Mac default occupied the first position of the Menuitem, and cannot change the label name

[leaanthony]

So is it that the docs need improving? It's not clear what's happening with this ticket 👍

[acheong08]

The documentation clearly includes

if runtime.GOOS == "darwin" {
    AppMenu.Append(menu.EditMenu())  // on macos platform, we should append EditMenu to enable Cmd+C,Cmd+V,Cmd+Z... shortcut
}

under Reference > Menus

[leaanthony]

Great. Can this be closed then?

[cxt90730]

@acheong08 @leaanthony Sorry, I may not express it clearly. According to the document, I cannot show the submenu File , because Mac default occupied the first position of the Menuitem, and cannot change the menu's label name. I must write code like this way first :

 AppMenu := menu.NewMenu()
	if os_runtime.GOOS == "darwin" {
		AppMenu.Append(menu.AppMenu())
	}

and then, I can add other menu that I customized or menu.EditMenu(), otherwise, the display will not be correct.

P.S. runtime.Quit() now is need arg ctx, so the example in Reference > Menus is wrong...

[acheong08]

Confirmed on MacOS 12.4. The first Menu will always be the Application menu on MacOS, documentation needs to be updated.

runtime.Quit() needs ctx which cannot be easily obtained in main.go. It is better to create a Quit function in app.go and set cmd+q to a.Quit()

[leaanthony]

Happy to accept a PR for your commit 👍

[cxt90730]

Awesome, thanks~