Feature: set browser path #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for raising this PR and updating the documentation. @stffabi any thoughts? |
stffabi
requested changes
Jun 15, 2022
v2/internal/frontend/desktop/windows/go-webview2/pkg/edge/chromium.go
Outdated
Show resolved
Hide resolved
v2/internal/frontend/desktop/windows/go-webview2/pkg/edge/chromium.go
Outdated
Show resolved
Hide resolved
added 2 commits
June 15, 2022 20:17
…for installed webview in manual strategy
auto-merge was automatically disabled
June 15, 2022 18:28
Head branch was pushed to by a user without write access
|
Would it be possible to use |
stffabi
reviewed
Jun 16, 2022
stffabi
approved these changes
Jun 24, 2022
leaanthony
approved these changes
Jun 24, 2022
|
Please fix merge conflicts and we should be good 👍 |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1446
This PR adds new webview2 strategy: manual
It won't download or notify user about webview2 installation status.
You must manually specify a path to a webview2 runtime in
windows.Optionsstructure.If the specified directory does not exist, it will try to use webview2 installed in the system.