-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/linux warnings #1656
Bugfix/linux warnings #1656
Conversation
Deploying with Cloudflare Pages
|
4edc15d
to
617f47b
Compare
@ianmjones - Please let me know if this fixes the warnings for you 👍 |
@@ -63,7 +74,10 @@ static void SetMinMaxSize(GtkWindow* window, int min_width, int min_height, int | |||
size.min_width = size.min_height = size.max_width = size.max_height = 0; | |||
|
|||
GdkRectangle monitorSize = getCurrentMonitorGeometry(window); | |||
int flags = GDK_HINT_MAX_SIZE | GDK_HINT_MIN_SIZE; | |||
if( isNULLRectangle(monitorSize) ) { | |||
return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make sure, do we still apply the constraints for a minimum or maximum in the options.Options
?
IIRC the call to SetMinMaxSize
for those is also very early and if the monitorSize couldn't be determined we would skip applying the constraints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't confirm tonight but it's interesting it worked at all with a null window. Potentially we'll need to hook on the "present"(?) Signal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the fix may cause issues with fullscreen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm min/max options do not get set on this branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixed the warnings for me. 🎉
I didn't have any issues using WindowFullscreen()
from JS either. 🤷
Min/Max size appears to work for me now after merging master. |
Multiple fixes for Linux warnings.
Fixes #1654
Fixes #1653