Bugfix/linux warnings #1656
Bugfix/linux warnings #1656
Conversation
Deploying with
|
| Latest commit: |
502c7a6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d57d1092.wails-website.pages.dev |
| Branch Preview URL: | https://bugfix-linux-warnings.wails-website.pages.dev |
leaanthony
force-pushed
the
bugfix/linux-warnings
branch
from
4edc15d to
617f47b
Compare
|
@ianmjones - Please let me know if this fixes the warnings for you 👍 |
| GdkRectangle monitorSize = getCurrentMonitorGeometry(window); | ||
| int flags = GDK_HINT_MAX_SIZE | GDK_HINT_MIN_SIZE; | ||
| if( isNULLRectangle(monitorSize) ) { | ||
| return; |
There was a problem hiding this comment.
Just to make sure, do we still apply the constraints for a minimum or maximum in the options.Options?
IIRC the call to SetMinMaxSize for those is also very early and if the monitorSize couldn't be determined we would skip applying the constraints.
There was a problem hiding this comment.
I can't confirm tonight but it's interesting it worked at all with a null window. Potentially we'll need to hook on the "present"(?) Signal.
There was a problem hiding this comment.
Looks like the fix may cause issues with fullscreen.
There was a problem hiding this comment.
Can confirm min/max options do not get set on this branch.
ianmjones
left a comment
ianmjones
left a comment
There was a problem hiding this comment.
This fixed the warnings for me. 🎉
I didn't have any issues using WindowFullscreen() from JS either. 🤷
|
Min/Max size appears to work for me now after merging master. |
Multiple fixes for Linux warnings.
Fixes #1654
Fixes #1653