Add frontend:dev:install configuration#1666
Add frontend:dev:install configuration#1666leaanthony merged 4 commits intowailsapp:masterfrom LGiki:feat/add-project-config-item
frontend:dev:install configuration#1666Conversation
|
This looks good to me! If @stffabi is happy, let's go! |
|
Thanks @LGiki for this. LGTM, there's just one thing which we might also need to change. During the build process we also execute an install command before the frontend is getting build. Currently we use the wails/v2/pkg/commands/build/base.go Lines 516 to 519 in d5574ba What do you think @leaanthony ? |
|
Yeah, good call. @LGiki this is what we do for the build command: wails/v2/pkg/commands/build/base.go Lines 533 to 547 in d5574ba |
|
I'm thinking about how we can also change |
…f it has been defined) to install the dependencies
|
Thanks, I've pushed a new commit that uses the same logic to handle the install command when building the frontend if it's called for a |
leaanthony
left a comment
There was a problem hiding this comment.
Looking good! Just one comment 👍👍👍
v2/pkg/commands/build/base.go
Outdated
|
|
||
| // Check there is an 'InstallCommand' provided in wails.json | ||
| if b.projectData.InstallCommand == "" { | ||
| var installCommand string |
There was a problem hiding this comment.
I think this can be simplified with the helper method you created! 🚀
There was a problem hiding this comment.
🚀 Thanks, I've simplified the logic of determining the installation command.
That'd be great if you could! I would do something like we've done already and check |
Yeah, I will create a PR to do this. 🚀 |
stffabi
left a comment
There was a problem hiding this comment.
LGTM 👍 , thanks so much for the time you have put into this.
Add a
frontend:dev:installconfiguration in wails.json to specify the dev dependencies installation command and update the docs.Fixes #1663