Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preact-ts template build fix #1781

Merged
merged 4 commits into from
Aug 27, 2022
Merged

preact-ts template build fix #1781

merged 4 commits into from
Aug 27, 2022

Conversation

Debdut
Copy link
Contributor

@Debdut Debdut commented Aug 23, 2022

Description

Default peact-ts template of wails throws error on wails dev

$ wails dev
Wails CLI v2.0.0-beta.44.2

Executing: go mod tidy -compat=1.17
Executing: wails generate module
Building frontend for development...
  - Installing frontend dependencies: Done.
  - Compiling frontend:     
    > frontend@0.0.0 build
    > tsc && vite build
    
    src/app.tsx(18,13): error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
    src/app.tsx(19,17): error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
    src/app.tsx(20,17): error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
    src/app.tsx(20,65): error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
    src/app.tsx(21,17): error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
    src/app.tsx(22,21): error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
    src/app.tsx(23,21): error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
    src/app.tsx(23,66): error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
    src/app.tsx(24,17): error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
    src/app.tsx(25,13): error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
    
    


ERROR: exit status 2

To Reproduce

wails init -n app -t preact-ts
wails dev

This pull request fixes it by importing the required TSX types.

Linked Issue

#1780

@leaanthony
Copy link
Member

Hey there 👋 Thanks for opening this 🙏 There's new templates on master using Vite 3. Please let us know if this works as expected. I won't merge this in as it will clash with it.

@leaanthony leaanthony merged commit 6c3418d into wailsapp:master Aug 27, 2022
@leaanthony
Copy link
Member

Confirmed fix and removed Fragment as it worked without it. Thanks for opening this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants