[webviewloader] Use go implementation to retrieve the version of a fixed runtime #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xed runtime This fixes a problem with the go-winloader and using GetAvailableCoreWebView2BrowserVersionString Fixes wailsapp#1569
Snider
approved these changes
Aug 26, 2022
|
LGTM! Thanks for taking the time to do this 🙏 |
|
Just checking you're happy for this to be merged? |
|
Yeah, I'm happy with the state of the PR and fine merging it. 👍 |
|
Thanks for taking your time looking into it. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1569