Skip to content

Better watcher - #1827

Merged
leaanthony merged 3 commits into
masterfrom
bugfix/too-many-open-files
Sep 3, 2022
Merged

leaanthony merged 3 commits into
masterfrom
bugfix/too-many-open-files

Conversation

@leaanthony

Copy link
Copy Markdown
Member

MacOS has really low limits on number of open files and fsnotifier smashes it, leading to too many open files errors. This PR greatly reduces the number of open files be using .gitignore as a basis for things that should not be watched.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 3, 2022 •

Copy link
Copy Markdown

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a59bec1
Status: ✅  Deploy successful!
Preview URL: https://367e2d3d.wails.pages.dev
Branch Preview URL: https://bugfix-too-many-open-files.wails.pages.dev

View logs

@stffabi stffabi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, that's a great enhancement 👍

"github.com/samber/lo"
)

type Watcher interface {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we don't need the Watcher interface at the moment. Should we remove it?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll keep it in for now as I really do want to use FSEvents for Mac

@leaanthony
leaanthony merged commit fca6e9e into master Sep 3, 2022
@leaanthony
leaanthony deleted the bugfix/too-many-open-files branch September 3, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants