Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] Fix frameless maximizing in multi monitor setup #2043

Conversation

stffabi
Copy link
Collaborator

@stffabi stffabi commented Nov 3, 2022

MonitorFromWindow is unreliable during a maximize, it might return the wrong monitor for the window or can't find one. As a result the webview2 remains blank/white.

See also MicrosoftEdge/WebView2Feedback#2549

Fixes #2042
Fixes #1941

MonitorFromWindow is unreliable during a maximize, it might return
the wrong monitor for the window or can't find one.

MicrosoftEdge/WebView2Feedback#2549
@stffabi stffabi force-pushed the bugfix/windows-frameless-multi-monitor-maxzimize branch from 5a843e1 to b6512dd Compare November 3, 2022 07:14
Copy link
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beast mode!

@stffabi stffabi merged commit 0a1c05d into wailsapp:master Nov 3, 2022
@stffabi
Copy link
Collaborator Author

stffabi commented Nov 3, 2022

Thanks for merging

@leaanthony
Copy link
Member

Thanks for Beast Mode PRs 💯

@stffabi stffabi deleted the bugfix/windows-frameless-multi-monitor-maxzimize branch November 8, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page is lost in frameless window when unminimise Screen goes blank and minimize and maximize on Windows
2 participants