Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React Hash Router Links returns 404 #2050

Merged
merged 2 commits into from Nov 17, 2022
Merged

React Hash Router Links returns 404 #2050

merged 2 commits into from Nov 17, 2022

Conversation

marvinhosea
Copy link
Contributor

The linked Hash Router link is not valid anymore and returns a 404.

@marvinhosea
React Hash Router Links returns 404
d19c864 
The linked Hash Router link is not valid anymore and returns a 404.
misitebao
misitebao reviewed Nov 8, 2022
View reviewed changes
Copy link
Contributor

@misitebao misitebao left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branch name does not conform to the rules.

@leaanthony
Copy link
Member

That's ok. I need to disable that check. It's basically useless

@leaanthony
Copy link
Member

Thanks @marvinhosea 🙏

@leaanthony leaanthony merged commit a8bbce6 into wailsapp:master Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misitebao misitebao misitebao left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marvinhosea @leaanthony @misitebao