Ability to define prefix / suffix for TS module

[OlegGulevskyy]

As discussed in the issue #2058 , this PR adds ability for the app developer to define prefix and suffix for their return entities from the backend. Those pref/suff will be used in the generated models.ts file, to avoid clash with JS reserved keywords.

• Added a full list of JS keywords and detection of the clash
• Added warning message for each type to the console log when the types are being converted. A note here: - I am not exactly happy how this warning implemented (it's a simple log and outputting it into stderr but I don't know any other better way, I'd love some guidance here.
• Made sure prefix / suffix are added in all modes - wails dev / wails build / wails generate module. Please let me know if I missed any other.

Some implementation details question:

1. Prefix and Suffix flags are implemented as structs that can be reimported (they have Flag and Description properties). Is this ok thing to do in Go lang? I thought of treating it as enum, because retyping it in all other places is error prone and if the flag needs to be changed - it can be just changed in one place and affect all the other.
2. What is the better way to implement warning logging for cases when there is a clash with JS reserved keyword?

Please don't hesitate to say what's not idiomatic way to do things, what does not make sense or what does, I am a webdev with JS/TS background and Go is my new tool in the toolbox, so I am just learning and open to any feedback!

Thanks in advance

[leaanthony]

Just a couple of comments 👍

[leaanthony]

In Go, you generally don't have ambiguous package names. In this instance you may want to call it "logutils" or something. It actually doesn't bother me so much, more an FYI 👍

[OlegGulevskyy]

great tip, thank you! will refactor it and keep it in mind!

[stffabi]

Awesome work, thanks @OlegGulevskyy 👍

Just a note which might be worth to be discussed:
I wonder if those settings should be put into wails.json. I think for most people that need to solve the ambiguity with JS keywords want this to be setup once for their project. Otherwise they would need to remember to define those options for every wails dev and for every wails build call, because we now generate the bindings for every build. Also if multiple people are working on one project they would need to remember those settings. And one needs to make sure to update the build server definition as well, if a company is using build agents. If it was defined in wails.json this would only need to be defined once and every one using that project would use the correct settings.

Thoughts?

[leaanthony]

That's a great call actually.

[OlegGulevskyy]

Agreed, that's a good call!
Looking at schema here, what would you say the properties could be?
My initial thinking is something like this

[leaanthony]

Perhaps ts_generation?

[OlegGulevskyy]

ts_generation works for me. What do you think? @stffabi

[stffabi]

ts_generation works for me. What do you think? @stffabi

Yeah that sounds good for me👍

[OlegGulevskyy]

Updated PR to use wails.json file to configure this one + updated json schema
Let me know if it looks good to you and I can update changelog

[leaanthony]

LGTM. One thing I'm going to suggest is a test in the binding_test directory to ensure it works as intended and we don't get regressions in the future 👍

[OlegGulevskyy]

Had busy few days with work, but got your comment, I haven't forgotten and will look into it! :)

[OlegGulevskyy]

Added a simple use cases for automated testing, to make sure the entity is generated with prefix and suffix whenever one or the other is supplied.
Let me know if you'd like me to cover some other cases :)

Thanks for your feedback and guidance, I appreciate it!

cc @leaanthony @stffabi

[leaanthony]

Just a few small suggestions 👍

[leaanthony]

Also, please update the CHANGELOG in the website directory so it isn't missed next release 👍🙏

[OlegGulevskyy]

Sure, all done! Let me know if the wording in changelog needs tweaking

[leaanthony]

Awesome first issue PR! :D