-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support GPU acceleration settings on Windows & Linux #2266
Support GPU acceleration settings on Windows & Linux #2266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Awesome, thanks for doing this. 👍
Just two minor comments and maybe you could also already add the changelog entry.
v2/internal/frontend/desktop/windows/go-webview2/pkg/edge/create_env_native.go
Show resolved
Hide resolved
I found a bug. If you don't set the linux options, the setup crashes. I'm fixing it now! |
1d8271b
to
78b9e63
Compare
Thanks @stffabi, I added the change log as well! |
You're welcome, thanks for doing this 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @lyimmi !!
This PR adds support for webview GPU settings on Windows and Linux as discussed in issue #2264.
Windows:
WebviewGpuIsDisabled
in windows.OptionsWebviewGpuIsDisabled
set to true the webview will be initialized with the--disable-gpu
switch.Linux:
WebviewGpuPolicy
in linux.Options.WebviewGpuPolicy
and three constants to be used as options.Mac:
This setting is not available.