Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2280 - code block highlights #2338

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Conversation

BuckeyeCoder
Copy link
Contributor

Code reviewed the entire site's code blocks for those that use a highlight. Found 3 that needed adjusting.

Only other change was from the Markdown linter which prefers underscores for italic text instead of asterisks for some reason. Either are allowed and assuming we all use the same linter I allowed the linter's opinionated change.

Did not see an AUTHORS.md to add to; if you need that to maintain MIT let me know and we'll add it.

Copy link
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to do this!

@leaanthony
Copy link
Member

leaanthony commented Feb 1, 2023

Did not see an AUTHORS.md to add to; if you need that to maintain MIT let me know and we'll add it.

We keep a list of contributors in the main project documentation, which is rendered here: https://wails.io/credits/#contributors

The source of this is: https://github.com/wailsapp/wails/blob/master/.all-contributorsrc

I think we could make this more obvious in the guide and keep it updated via actions.

We also encourage everyone to update CHANGELOG.md. I go through each commit and update it prior to releases but it's better if it's done as the PRs are done.

@leaanthony leaanthony merged commit 709244c into wailsapp:master Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants