[v2, windows] Handle webview2 process crashes and add DisableWebViewRendererCodeIntegrity flag #2627

stffabi · 2023-04-27T06:01:36Z

This should help for all those issue where no Window comes up:

cloudflare-pages · 2023-04-27T15:30:15Z

Deploying with Cloudflare Pages

Latest commit:	`80d64fa`
Status:	✅ Deploy successful!
Preview URL:	https://54ac394d.wails.pages.dev
Branch Preview URL:	https://feature-webview2-process-cra.wails.pages.dev

View logs

AlbinoDrought · 2023-04-27T17:42:48Z

I can confirm this works for me, thanks! 👍

Dialog when webview crashes:

--disable-features contains RendererCodeIntegrity when Windows.WebviewDisableRendererCodeIntegrity=true:

stffabi · 2023-04-27T19:19:22Z

Awesome, thanks for testing 🙏

leaanthony

Awesome job! Thank you 🙏

leaanthony · 2023-04-27T20:57:10Z

...nternal/frontend/desktop/windows/go-webview2/pkg/edge/ICoreWebView2ProcessFailedEventArgs.go

+}
+
+func (i *ICoreWebView2ProcessFailedEventArgs) GetProcessFailedKind() (COREWEBVIEW2_PROCESS_FAILED_KIND, error) {
+	kind := COREWEBVIEW2_PROCESS_FAILED_KIND(0xffffffff)


Just wondering if this would fail on 32bit (not that we support it! 😅)

Just tried it, works fine 😄

stffabi · 2023-04-27T21:03:34Z

Thanks for approving 🙏

ziveni · 2023-05-14T12:01:20Z

I can confirm this works for me, thanks! 👍

Dialog when webview crashes:

--disable-features contains RendererCodeIntegrity when Windows.WebviewDisableRendererCodeIntegrity=true:

I don't understand how you tested it successfully

lilili87222 · 2023-05-15T02:05:11Z

github.com/wailsapp/wails/v2 v2.5.0

start fail with following errors and blank window on some computer
Err | WebVie2wProcess failed with kind 1
Err | WebVie2wProcess failed with kind 1

stffabi · 2023-05-15T05:10:41Z

github.com/wailsapp/wails/v2 v2.5.0

start fail with following errors and blank window on some computer

Err | WebVie2wProcess failed with kind 1

Err | WebVie2wProcess failed with kind 1

There's not really much we can do here against these crashes. The best we can do is to make sure the underlying webview error page is shown, which we tried to achieve with this PR. If that chromium error is not shown this either means the webview is still hidden or the webview itself does not show one.
Because none of us was able to reproduce this, we can only add some handling and wait until we get a feedback from those affected from this.
You might try to change the code where the error is handled and tries to make sure the webview and window is getting unhidden. You could maybe try to first do a chromium.hide() then a chromium.show(). Maybe that helps to bring up the error page. You can also take a look into the windows eventviewer which should show the error that happened.

Almost all those crashes are caused by wrongly signed dlls injected into the webview process, which is getting detected and causes the renderer to stop. This is something done in the webview2 by microsoft and ot by Wails.
If you want you can try to use the new disablerendererintegritycheck flag to disable this, but please be aware of the security implications this has as stated on the comment of the flag.

ziveni · 2023-05-15T05:40:44Z

github.com/wailsapp/wails/v2 v2.5.0
start fail with following errors and blank window on some computer
Err | WebVie2wProcess failed with kind 1
Err | WebVie2wProcess failed with kind 1

There's not really much we can do here against these crashes. The best we can do is to make sure the underlying webview error page is shown, which we tried to achieve with this PR. If that chromium error is not shown this either means the webview is still hidden or the webview itself does not show one. Because none of us was able to reproduce this, we can only add some handling and wait until we get a feedback from those affected from this. You might try to change the code where the error is handled and tries to make sure the webview and window is getting unhidden. You could maybe try to first do a chromium.hide() then a chromium.show(). Maybe that helps to bring up the error page. You can also take a look into the windows eventviewer which should show the error that happened.

Almost all those crashes are caused by wrongly signed dlls injected into the webview process, which is getting detected and causes the renderer to stop. This is something done in the webview2 by microsoft and ot by Wails. If you want you can try to use the new disablerendererintegritycheck flag to disable this, but please be aware of the security implications this has as stated on the comment of the flag.

I have disabled this feature as prompted, and now it works fine

ziveni · 2023-05-15T12:15:16Z

I resolved this issue by configuring this environment variable to disable integrity checking. Please note that renderer code integrity checking is a security mechanism that ensures the loaded renderer code has not been tampered with or damaged. Disabling this feature allows bypassing the renderer code integrity check but reduces security.

stffabi · 2023-05-15T12:28:51Z

Please use the appropriate provided flag for this:

wails/v2/pkg/options/windows/windows.go

Lines 107 to 115 in c1a0e13

    
           // WebviewDisableRendererCodeIntegrity disables the `RendererCodeIntegrity` of WebView2. Some Security Endpoint 
        
           // Protection Software inject themself into the WebView2 with unsigned or wrongly signed dlls, which is not allowed 
        
           // and will stop the WebView2 processes. Those security software need an update to fix this issue or one can disable 
        
           // the integrity check with this flag. 
        
           // 
        
           // The event viewer log contains `Code Integrity Errors` like mentioned here: https://github.com/MicrosoftEdge/WebView2Feedback/issues/2051 
        
           // 
        
           // !! Please keep in mind when disabling this feature, this also allows malicious software to inject into the WebView2 !! 
        
           WebviewDisableRendererCodeIntegrity bool

Env variables should not work because we didn't support that for the native webview2loader and this seems to be a bug in the new webview2loader. So this is going to be fixed pretty soon.

…endererCodeIntegrity flag (#2627) * Add flag to disable webview RendererCodeIntegrity checks * Handle webview2 process crashes

AlbinoDrought · 2023-11-08T23:51:51Z

WebviewDisableRendererCodeIntegrity may be obsolete on 118+: https://github.com/MicrosoftEdge/WebView2Feedback/pull/4134/files

This was referenced Apr 27, 2023

start up fail none gui displayed on windows #2529

Closed

> windows11 专业版 22621.1413 编译的exe无法正常运行 #2615

Closed

Windows build hangs forever on startup #2124

Closed

stffabi added 2 commits April 27, 2023 17:29

[v2, windows] Add flag to disable webview RendererCodeIntegrity checks

2f9de13

[v2, windows] Handle webview2 process crashes

80d64fa

stffabi force-pushed the feature/webview2-process-crashes-and-flag branch from 0ef44af to 80d64fa Compare April 27, 2023 15:30

stffabi marked this pull request as ready for review April 27, 2023 19:19

stffabi requested a review from leaanthony April 27, 2023 19:19

leaanthony approved these changes Apr 27, 2023

View reviewed changes

stffabi merged commit 3853d2d into master Apr 27, 2023
12 checks passed

stffabi deleted the feature/webview2-process-crashes-and-flag branch April 27, 2023 21:03

misitebao pushed a commit that referenced this pull request May 27, 2023

[v2, windows] Handle webview2 process crashes and add DisableWebViewR…

c8ce0ee

…endererCodeIntegrity flag (#2627) * Add flag to disable webview RendererCodeIntegrity checks * Handle webview2 process crashes

josStorer referenced this pull request in josStorer/RWKV-Runner Mar 31, 2024

update manifest.json

f6614ff

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[v2, windows] Handle webview2 process crashes and add DisableWebViewRendererCodeIntegrity flag #2627

[v2, windows] Handle webview2 process crashes and add DisableWebViewRendererCodeIntegrity flag #2627

stffabi commented Apr 27, 2023

cloudflare-pages bot commented Apr 27, 2023 •

edited

Loading

AlbinoDrought commented Apr 27, 2023

stffabi commented Apr 27, 2023

leaanthony left a comment

leaanthony Apr 27, 2023

stffabi Apr 27, 2023

stffabi commented Apr 27, 2023

ziveni commented May 14, 2023

lilili87222 commented May 15, 2023

stffabi commented May 15, 2023

ziveni commented May 15, 2023

ziveni commented May 15, 2023

stffabi commented May 15, 2023

AlbinoDrought commented Nov 8, 2023

[v2, windows] Handle webview2 process crashes and add DisableWebViewRendererCodeIntegrity flag #2627

[v2, windows] Handle webview2 process crashes and add DisableWebViewRendererCodeIntegrity flag #2627

Conversation

stffabi commented Apr 27, 2023

cloudflare-pages bot commented Apr 27, 2023 • edited Loading

Deploying with Cloudflare Pages

AlbinoDrought commented Apr 27, 2023

stffabi commented Apr 27, 2023

leaanthony left a comment

Choose a reason for hiding this comment

leaanthony Apr 27, 2023

Choose a reason for hiding this comment

stffabi Apr 27, 2023

Choose a reason for hiding this comment

stffabi commented Apr 27, 2023

ziveni commented May 14, 2023

lilili87222 commented May 15, 2023

stffabi commented May 15, 2023

ziveni commented May 15, 2023

ziveni commented May 15, 2023

stffabi commented May 15, 2023

AlbinoDrought commented Nov 8, 2023

cloudflare-pages bot commented Apr 27, 2023 •

edited

Loading