Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows/nsis: add hidpi support for nsis installer #2694

Merged
merged 2 commits into from Jun 3, 2023

Conversation

5aaee9
Copy link
Contributor

@5aaee9 5aaee9 commented Jun 1, 2023

Description

Enable Hi-DPI support for NSIS installer on windows, fix low resolution installer.

https://nsis.sourceforge.io/Reference/ManifestDPIAware

In before

image

After the option (text is more clear)

image

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using wails doctor.

  • Windows
  • macOS
  • Linux

Test Configuration

Please paste the output of wails doctor. If you are unable to run this command, please describe your environment in as much detail as possible.

Checklist:

  • I have updated website/src/pages/changelog.mdx with details of this PR
  • My code follows the general coding style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@leaanthony
Copy link
Member

Thanks for this awesome PR! I did a quick read here on the caveats: https://nsis.sourceforge.io/Reference/ManifestDPIAware any thoughts on these?

@5aaee9
Copy link
Contributor Author

5aaee9 commented Jun 2, 2023

@leaanthony I think is no problem to enable it on default

  • NSIS 3.0 is released 7 years ago, so the chance to use plugin which has compatibility issues is low
  • And it's used windly: Signal Desktop, VLC

@leaanthony
Copy link
Member

I've made a couple of suggestions so that people can find details on this setting. Please could you add an entry to the changelog located at website/src/pages/changelog.mdx.

@5aaee9
Copy link
Contributor Author

5aaee9 commented Jun 3, 2023

@leaanthony Added

Copy link
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to do this 🙏

@leaanthony leaanthony merged commit 6d857bf into wailsapp:master Jun 3, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants