[v2] Add smart default context-menu functionality (backported from v3) #2748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leaanthony
requested changes
Jun 27, 2023
| This rule is inherited like any normal CSS rule, so nesting works as expected. | ||
|
|
||
| :::note | ||
| This filtering functionality is only enabled in production, so in development and in debug build, the full context-menu is always available everywhere. |
There was a problem hiding this comment.
I think that if you right click a background with no text in debug mode, it won't be available as the current check is CSS only - it has no idea it's in dev mode. We could implement that by setting flags.debug to true and checking it as part of processDefaultContextMenu
There was a problem hiding this comment.
It skips it all together in the runtime in dev & debug :
So right clicking anywhere shows the context menu in dev & debug, that's why I needed the previous PR 😉
You can test locally to confirm 👍
There was a problem hiding this comment.
Ooooh! I totally missed that nuance! Awesome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR backports the "smart" default context-menu functionality from v3.
This feature allows the default context-menu to only be available in text contexts by default, which can be controlled with the
--default-contextmenuCSS style, this feature only works in production, in dev & debug the full default context-menu is always enabled.Reference #2733
Type of change
How Has This Been Tested?
How to test :
Enable the
EnableDefaultContextMenuapp option, then using this index.zip html file, you can test all scenarios, in production it should work, in dev & debug it should have no effect and the default context-menu should always be available.Checklist:
website/src/pages/changelog.mdxwith details of this PR