Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter the base directory from ignoreDirs #2869

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Conversation

haukened
Copy link
Contributor

Description

grabs the base directory name using filesystem.Base(cwd) and ensures that that directory, which is the top level of the project, is never filtered by a .gitignore entry.

Fixes #2867

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

compiled v2/cmd/wails as wails-dev and re-ran in the same context that the issue was created with. confirmed resolution of the top level directory always being included.

  • Linux

Test Configuration

╭─david@arch ~  
╰─➤  wails doctor
Wails CLI v2.5.1

 SUCCESS  Done.                                                                                                                                             

# System

OS           | Arch Linux
Version      | Unknown   
ID           | arch      
Go Version   | go1.21.0  
Platform     | linux     
Architecture | amd64     

# Wails

Version         | v2.5.1
Package Manager | pacman

# Dependencies

Dependency | Package Name | Status    | Version    
*docker    | docker       | Installed | 1:24.0.5-1 
gcc        | gcc          | Installed | 13.2.1-3   
libgtk-3   | gtk3         | Installed | 1:3.24.38-1
libwebkit  | webkit2gtk   | Installed | 2.40.5-1   
npm        | npm          | Installed | 9.8.1-1    
pkg-config | pkgconf      | Installed | 1.8.1-1    
* - Optional Dependency

# Diagnosis

Your system is ready for Wails development!

Checklist:

  • I have updated website/src/pages/changelog.mdx with details of this PR
  • My code follows the general coding style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 🙏

@leaanthony
Copy link
Member

Sorry this took so long! Thanks for this! 🙏

@leaanthony leaanthony merged commit ab0b0f8 into wailsapp:master Sep 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

processDirectories() fails to return any directories if .gitignore contains directory/project/binary name
2 participants