filter the base directory from ignoreDirs#2869
Merged
leaanthony merged 3 commits intowailsapp:masterfrom Sep 25, 2023
Merged
Conversation
Member
|
Sorry this took so long! Thanks for this! 🙏 |
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
grabs the base directory name using
filesystem.Base(cwd)and ensures that that directory, which is the top level of the project, is never filtered by a.gitignoreentry.Fixes #2867
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
compiled
v2/cmd/wailsaswails-devand re-ran in the same context that the issue was created with. confirmed resolution of the top level directory always being included.Test Configuration
Checklist:
website/src/pages/changelog.mdxwith details of this PR