[v2, windows] Support async request processing on AssetServer #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
0d00d30
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1e7d2a3b.wails.pages.dev |
| Branch Preview URL: | https://feature-assetserver-windows.wails.pages.dev |
leaanthony
approved these changes
Sep 19, 2023
stffabi
force-pushed
the
feature/assetserver-windows-deferred
branch
from
f1f2fd4
to
0d00d30
Compare
|
You're welcome and thanks for approving. |
mmghv
reviewed
Sep 25, 2023
Comment on lines
+23
to
+24
| - AssetServer requests are now processed asynchronously without blocking the main thread on Windows. Changed by @stffabi in [PR](https://github.com/wailsapp/wails/pull/2926) | ||
| - AssetServer requests are now processed concurrently by spawning a goroutine per request. Changed by @stffabi in [PR](https://github.com/wailsapp/wails/pull/2926) |
There was a problem hiding this comment.
Duplicate record?
When fixing this please merge it with the other Changed section, got mixed with the devtools PR, don't know how it didn't get marked as conflict.
There was a problem hiding this comment.
PR #2940 is up to fix the duplicate changed section that came in with the devtools PR.
There was a problem hiding this comment.
Merged. Git black magic bites again
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2890