Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docs for NixOS css bug #3268

Merged
merged 1 commit into from Feb 19, 2024
Merged

Add Docs for NixOS css bug #3268

merged 1 commit into from Feb 19, 2024

Conversation

atterpac
Copy link
Contributor

@atterpac atterpac commented Feb 19, 2024

Adds docs to help resolve the issue of NixOS/Wayland not being able to change the font size

Fixes # (issue)
No issue, bug reported in discord help channel

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [X ] This change requires a documentation update

Test Configuration

No functional changes made

Summary by CodeRabbit

  • Documentation
    • Introduced a guide for resolving font-size rendering issues on NixOS/Wayland.
    • Added documentation to address the NixOs/Wayland font-size CSS issue.
    • Fixed Vue-TS template build error.

Copy link
Contributor

coderabbitai bot commented Feb 19, 2024

Warning

Rate Limit Exceeded

@atterpac has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 20 minutes and 38 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 9c3f91b and 3bbe0a1.

Walkthrough

This update brings a new Dockerfile that sets up an environment with necessary dependencies and installs Wails in a specific branch. Additionally, a guide addresses a font-size bug in NixOS/Wayland setups by adjusting devShell configurations.

Changes

Files Change Summary
v3/dockerfile Introduced a Dockerfile setting up an environment and installing Wails.
website/docs/guides/nixos-font.mdx Added a guide for fixing font-size rendering in NixOS/Wayland by adjusting devShell.

🐰✨
In the world of code and docker dreams,
A Dockerfile emerged with new themes.
NixOS and Wayland, fonts askew,
But with a guide, the solution grew.
Bugs beware, for we bring the light,
Through code and docs, all is set right.
🌟📄

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 3

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 9c3f91b and cb74131.
Files selected for processing (1)
  • website/docs/guides/nixos-font.mdx (1 hunks)

@@ -0,0 +1,10 @@
# NixOS FontSize
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title "NixOS FontSize" could be more descriptive to immediately inform the reader about the content's focus. Consider a title that reflects the workaround nature of the content, such as "Fixing Font Size Issue on NixOS/Wayland".

@@ -0,0 +1,10 @@
# NixOS FontSize

NixOS/Wayland can cause a bug where the `font-size` css property does affect the rendered page. To fix this add the following to your devShell.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a minor typo in the description: "does affect" should be "does not affect". This correction is crucial for accurately conveying the problem being addressed.

- NixOS/Wayland can cause a bug where the `font-size` css property does affect the rendered page.
+ NixOS/Wayland can cause a bug where the `font-size` css property does not affect the rendered page.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
NixOS/Wayland can cause a bug where the `font-size` css property does affect the rendered page. To fix this add the following to your devShell.
NixOS/Wayland can cause a bug where the `font-size` css property does not affect the rendered page. To fix this add the following to your devShell.

Comment on lines +5 to +9
```shell
shellHook = with pkgs; ''
export XDG_DATA_DIRS=${gsettings-desktop-schemas}/share/gsettings-schemas/${gsettings-desktop-schemas.name}:${gtk3}/share/gsettings-schemas/${gtk3.name}:$XDG_DATA_DIRS;
export GIO_MODULE_DIR="${pkgs.glib-networking}/lib/gio/modules/";
'';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shell script provided is clear and seems appropriate for the described workaround. However, it would be beneficial to add a brief explanation of what each export command does for readers who might not be familiar with these settings. This can enhance understanding and trust in the provided solution.

@atterpac atterpac force-pushed the master branch 4 times, most recently from 1a2c374 to 26d4063 Compare February 19, 2024 18:48
add changelog

Appeasing the rabbit

remove v3
Copy link
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @atterpac 🙏

@leaanthony leaanthony merged commit 57e6834 into wailsapp:master Feb 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants