Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store api key outside atom config file #26

Closed
alanhamlett opened this issue Sep 11, 2015 · 5 comments
Closed

store api key outside atom config file #26

alanhamlett opened this issue Sep 11, 2015 · 5 comments

Comments

@alanhamlett
Copy link
Member

because submitting traceback automatically includes secret api key in public github issue.

@albertosantini
Copy link

and we cannot commit the settings to a public repo to sync the preferences.

Update: for instance in ~/.wakatime.cfg

@alanhamlett
Copy link
Member Author

I was going to move the api key from atom config into ~/.wakatime.cfg. Do you store your ~/.wakatime.cfg file on a public repo?

@albertosantini
Copy link

No. dotfiles containing sensible info are not synced and it is a fair decision.

alanhamlett added a commit that referenced this issue Oct 26, 2015
Allow to read key from ~/.wakatime.cfg. Close #26.
@alanhamlett alanhamlett reopened this Oct 26, 2015
@alanhamlett
Copy link
Member Author

Still need to prevent api keys from being stored in the Atom config file, even if it's read from ~/.wakatime.cfg by default.

@albertosantini
Copy link

With 5.0.1 I removed api key from the atom settings, using the key stored in ~/.wakatime.cfg.

For me it would be enough to add a text in the atom settings, warning the api key would be stored in atom config file.

Likely https://github.com/wakatime/atom-wakatime/blob/master/lib/wakatime.coffee#L28

Your secret key from https://wakatime.com/settings. Be aware, if filled, it is stored in config file.

Edit: Then you may close the issue. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants