Use WAKATIME_HOME env #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanhamlett
reviewed
Jan 24, 2018
| @@ -47,6 +47,13 @@ public static boolean isPythonInstalled() { | |||
|
|
|||
| public static String getResourcesLocation() { | |||
| if (Dependencies.resourcesLocation == null) { | |||
| if (System.getenv("WAKATIME_HOME")) { | |||
| File appDataFolder = new File(System.getenv("WAKATIME_HOME")); | |||
There was a problem hiding this comment.
We don't need to define appDataFolder here, it's only used to find the window's data folder when WAKATIME_HOME isn't defined.
There was a problem hiding this comment.
I've removed it in a separate commit, and will release a new version soon after testing (probably within a few days). Thanks!
There was a problem hiding this comment.
Wow, that was quick! Thanks again for the awesome project.
There was a problem hiding this comment.
@alanhamlett thoughts on a new version?
There was a problem hiding this comment.
But that merge hasn't been put into a new version right?
There was a problem hiding this comment.
Oh, right! Just released a new version 9.0.2 with your change.
|
fyi, haven't been able to get this to work running 9.03 - it creates the folder and prompts me for an API key. As usual, it can be tricky to get environment variables into GUI programs but usually my startup.plist file handles it. Also, I tried opening it up with IntelliJ IDEA 2017.3.5 (Ultimate Edition) I'm not so experienced with building Java projects, but at some point perhaps I'll circle back around to build it and see what's happening. |
resolutionSeems like I got this working - there were two debuggingHey @alanhamlett - would like to debug this, but I'm not a good enough Java/Intellij developer to figure out how to automatically load the plugin? I left some comments at https://gitter.im/IntelliJ-Plugin-Developers/Lobby?at=5ac1126a7c3a01610d98b010
I get the impression from http://www.jetbrains.org/intellij/sdk/docs/basics/plugin_structure/plugin_content.html that I need to bundle this all into a jar file for it to be automatically loaded? Also tried moving the
I also see: but I can't seem to set it to the bundled version for some reason (the macOS |
|
For any MacOS users that are having issues getting IntelliJ to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, following up on https://github.com/wakatime/wakatime/issues/73#issuecomment-312964355 - seems that the jetbrains plugin is creating
.wakatime/wakatime-master/and ignoring WAKATIME_HOMEThis is just a start, haven't tested it - not much of a Java person - probably still need to add code to read... I may get around to it eventually, or you can take it from here