Implement event source monitoring with app-specific heuristics #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n and Apple Notes supported for now)
starbugs
changed the title
starbugs
changed the title
alanhamlett
requested changes
Mar 8, 2024
There was a problem hiding this comment.
We should remove all apps except Figma from electronAppIds since we used that to attempt enabling electron's accessibility features, which are usually disabled for Electron apps by default. I did something bad, and used that isElectronApp to decide when to use the window's title as entity but we should change it back to only using isElectronApp for enabling Electron's accessibility features, and instead use isXcodeApp to decide when to use mouse & keyboard polling or not.
This was referenced Mar 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #205.