Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get latest tag #24

Merged
merged 1 commit into from Sep 6, 2021
Merged

Fix get latest tag #24

merged 1 commit into from Sep 6, 2021

Conversation

gandarez
Copy link
Member

@gandarez gandarez commented Sep 6, 2021

This PR fixes latest tag function to properly return latest valid tag.

Fixes https://github.com/wakatime/wakatime-cli/runs/3519989204?check_suite_focus=true

@gandarez gandarez added the bug Something isn't working label Sep 6, 2021
@gandarez gandarez self-assigned this Sep 6, 2021
alanhamlett
alanhamlett reviewed Sep 6, 2021
View reviewed changes
Copy link
Member

@alanhamlett alanhamlett left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get a sha instead of tag when running git rev-list. Is that going to work?

git rev-list --tags --max-count=1
4b5fad4fe6ea43f21a93097d8fe7d10f9b79a14e

Edit: Nevermind I see the next line gets the tag for that sha. 👍

@gandarez gandarez merged commit 44c4935 into master Sep 6, 2021
@gandarez gandarez deleted the bugfix/next-semver branch September 6, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanhamlett alanhamlett alanhamlett approved these changes

Assignees

@gandarez gandarez

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gandarez @alanhamlett