Symlink require administrator on Windows #122

moeshin · 2022-01-06T11:47:41Z

We can:

Require administrator
Download directly as ~/.wakatime/wakatime-cli

Lines 59 to 64 in 7a6d776

    
           link = os.path.join(getResourcesFolder(), 'wakatime-cli') 
        
           if not os.path.exists(link): 
        
               try: 
        
                   os.symlink(getCliLocation(), link) 
        
               except: 
        
                   pass

Handle exceptions by copying file

...

The text was updated successfully, but these errors were encountered:

moeshin · 2022-01-06T13:58:49Z

And the suffix of the executable file require be .exe in nvim.

E903: Process failed to start: no such file or directory

alanhamlett · 2022-01-06T15:29:54Z

If you copy the file to ~/.wakatime/wakatime-cli (without .exe) does it work? We can have the install script do the same on Windows.

moeshin · 2022-01-06T15:34:42Z

vim work, nvim no work:

E903: Process failed to start: no such file or directory: "C:/Users/MoeShin/.wakatime/wakatime-cli"

moeshin · 2022-01-06T15:45:21Z

They can all work with .exe.

vim-wakatime/scripts/install_cli.py

Line 59 in 7a6d776

link = os.path.join(getResourcesFolder(), 'wakatime-cli')

if is_win:
    link += '.exe'

alanhamlett · 2022-01-06T15:50:20Z

How about now, after 3bdb70e?

moeshin · 2022-01-06T16:07:25Z

nvim no run install_cli.py

moeshin · 2022-01-06T17:11:25Z

nvim no run install_cli.py

#123

alanhamlett · 2022-01-06T17:32:50Z

What's your output when you run this in Vim and Nvim?

:echo &shell

We can't assume &shell always accepts argument -c from #123, so I'll push a change now for you to test.

moeshin · 2022-01-06T17:39:59Z

In vim (MSYS2)

echo &shell
" D:/msys64/usr/bin/zsh

echo &shellcmdflag
" -c

In nvim (MSYS2)

echo &shell
" D:/msys64/usr/bin/zsh

echo &shellcmdflag
" /s /c

In vim (CMD)

echo &shell
" C:\WINDOWS\system32\cmd.exe

echo &shellcmdflag
" /c

In nvim (CMD)

echo &shell
" cmd.exe

echo &shellcmdflag
" /s /c

alanhamlett · 2022-01-06T17:43:00Z

I just pushed 55d42cf. Can you update and see if it fixes things for you on Vim and Nvim?

alanhamlett · 2022-01-06T17:43:27Z

Also, thanks for &shellcmdflag I had forgotten to ask for that output too!

moeshin · 2022-01-06T17:56:20Z

In MSYS2

[WakaTime] 127: /usr/bin/zsh: can't open input file: /s /c

echo &shell
" D:/msys64/usr/bin/zsh

echo &shellcmdflag
" /s /c

alanhamlett · 2022-01-06T18:13:25Z

How about now after debf1ef? Thanks for helping debug this!

moeshin · 2022-01-06T18:27:58Z

in MSYS2 only nvim

[WakaTime] 127: /usr/bin/zsh: can't open input file: /s

in CMD

[WakaTime] 2: /usr/bin/python3: can't open file '/c/Users/MoeShin/C:/Users/MoeShin/.vim/plugged/vim-wakatime/scripts/install_cli.py': [Errno 2] No such file or directory

By the way，I python3 install by pacman on MSYS2.

alanhamlett · 2022-01-06T18:37:57Z

Some cleanup with 49591ed so now Vim and NVim both use the same command. Maybe this will help simplify debugging. Can you update and try it out?

moeshin · 2022-01-06T18:55:26Z

no change

alanhamlett · 2022-01-06T19:11:56Z

If you revert plugin/wakatime.vim back to the state it was in from your PR #123 (1d87845) I'm curious does it work in all variants Vim/NVim/CMD/MSYS2?

moeshin · 2022-01-06T19:16:27Z

No, it has bug.
I have rolled back and modified moeshin@3e54260

moeshin · 2022-01-06T19:24:44Z

The problem is in python.
Python3 installed by pacman in MSYS2, the script path require unix style.

[WakaTime] 2: /usr/bin/python3: can't open file '/c/Users/MoeShin/C:/Users/MoeShin/.vim/plugged/vim-wakatime/scripts/install_cli.py': [Errno 2] No such file or directory

alanhamlett · 2022-01-06T19:38:58Z

So the path for install_cli.py that works in MSYS2 is this?
//c/Users/MoeShin/C//Users/MoeShin/.vim/plugged/vim-wakatime/scripts/install_cli.py

After let install_script = '/' . substitute(install_script, ':', '/', ''). Is the double slash at start necessary or does it work with a single slash? Does it work if you do this:

let install_script = "/C:/Users/MoeShin/.vim/plugged/vim-wakatime/scripts/install_cli.py"

moeshin · 2022-01-06T19:47:33Z

no. let install_script = "/C/Users/MoeShin/.vim/plugged/vim-wakatime/scripts/install_cli.py" is work

alanhamlett · 2022-01-06T20:17:28Z

Can you try now after 36f7f5c?

moeshin · 2022-01-06T20:23:17Z

no change

alanhamlett · 2022-01-06T20:31:47Z

That's strange, I thought it would be the fix.

Can you add line:
echo install_script just after the let install_script?

moeshin · 2022-01-06T20:34:33Z

install_script: C:/Users/MoeShin/.vim/plugged/vim-wakatime/scripts/install_cli.py

alanhamlett · 2022-01-06T20:36:01Z

You've removed the override from before? Want to make sure this line is deleted:
let install_script = "/C:/Users/MoeShin/.vim/plugged/vim-wakatime/scripts/install_cli.py"

alanhamlett · 2022-01-06T20:41:12Z

I'm not sure how it could remove the /c/Users/MoeShin/ prefix and be left with C:/ with a colon and no starting slash...

Maybe the substitute from 36f7f5c isn't running and the path changed some other way?

moeshin · 2022-01-06T20:44:03Z

Run console

C:\Users\MoeShin>python3 C:/Users/MoeShin/.vim/plugged/vim-wakatime/scripts/install_cli.py
python3: can't open file '/c/Users/MoeShin/C:/Users/MoeShin/.vim/plugged/vim-wakatime/scripts/install_cli.py': [Errno 2] No such file or directory

alanhamlett · 2022-01-07T15:04:55Z

I'm sorry, I had a bug in my regex. Fixed with 1316c05.

moeshin · 2022-01-07T15:56:34Z

Run 1316c05

zsh+nvim(scoop)
zsh+vim(msys2)
cmd+vim(msys2)
zsh+vim(scoop)

[WakaTime] /usr/bin/zsh: can't open input file: /c

cmd+nvim(scoop)
cmd+vim(scoop)

[WakaTime] 2: /usr/bin/python3: can't open file '/c/Users/MoeShin/C:/Users/MoeShin/.vim/plugged/vim-wakatime/scripts/install_cli.py': [Errno 2] No such file or directory

alanhamlett · 2022-01-07T16:03:37Z

Can you re-run those tests with a0daba9?

alanhamlett · 2022-01-07T16:06:10Z

Also, would be helpful for each of the checkboxes above to have the values of &shell and &shellcmdflag. Just once, like your comment above please 😄

moeshin · 2022-01-07T16:16:41Z

Run a0daba9

echom '`'.&shell.'`+`'.&shellcmdflag.'`'

zsh+vim(msys2)+/usr/bin/zsh+-c
zsh+vim(scoop)+D:/msys64/usr/bin/zsh+-c
zsh+nvim(scoop)+D:/msys64/usr/bin/zsh+/s /c
cmd+vim(msys2)+sh+-c
cmd+vim(scoop)+C:\WINDOWS\system32\cmd.exe+/c
cmd+nvim(scoop)+cmd.exe+/s /c

[WakaTime] 2: /usr/bin/python3: can't open file '/c/Users/MoeShin/C:/Users/MoeShin/.vim/plugged/vim-wakatime/scripts/install_cli.py': [Errno 2] No such file or directory

moeshin · 2022-01-07T16:24:33Z

Currently this bug is caused by the python version (installed by pacman on msys2).
It doesn't matter whether this vim or nvim runs on msys2.

And the msys2 installation folder can be customized https://www.msys2.org/.
May not contain msys.

Enter your desired Installation Folder (short ASCII-only path on a NTFS volume, no accents, no spaces, no symlinks, no subst or network drives, no FAT).

alanhamlett · 2022-01-07T16:30:09Z

Could you also run the same echo shell test with echo s:plugin_root_folder?

alanhamlett · 2022-01-07T16:33:34Z

And the msys2 installation folder can be customized https://www.msys2.org/. May not contain msys.

Oh, that makes things much more difficult. I'm just worried about overwriting &shell for all Windows users, in case cmd.exe isn't in their path and we break things for someone.

We also can't run system() in the foreground during startup, but maybe we can async run python -VV.

moeshin · 2022-01-07T16:51:27Z

cmd+vim(msys2)
s:IsMSYS(): 0
s:plugin_root_folder: /c/Users/MoeShin/.vim/plugged/vim-wakatime

cmd+vim(scoop)
s:IsMSYS(): 0
s:plugin_root_folder: C:/Users/MoeShin/.vim/plugged/vim-wakatime

cmd+nvim(scoop)
s:IsMSYS(): 0
s:plugin_root_folder: C:/Users/MoeShin/.vim/plugged/vim-wakatime

zsh+vim(msys2)
s:IsMSYS(): 0
s:plugin_root_folder: /c/Users/MoeShin/.vim/plugged/vim-wakatime

zsh+vim(scoop)
s:IsMSYS(): 1
s:plugin_root_folder: /C/Users/MoeShin/.vim/plugged/vim-wakatime

zsh+nvim(scoop)
s:IsMSYS(): 1
s:plugin_root_folder: /C/Users/MoeShin/.vim/plugged/vim-wakatime

In vim(msys2)

has('win32') == 0
has('unix') == 1

moeshin · 2022-01-07T17:07:19Z

Or re-run with unix style path when python exit code == 2

moeshin · 2022-01-07T17:23:34Z

I'm just worried about overwriting &shell for all Windows users, in case cmd.exe isn't in their path and we break things for someone.

Or override shellcmdflag?

moeshin · 2022-01-07T17:31:16Z

zsh+vim(msys2)

echo &shell
" D:/msys64/usr/bin/zsh

echo &shellcmdflag
" -c

zsh+vim(scoop)

echo &shell
" D:/msys64/usr/bin/zsh

echo &shellcmdflag
" At startup:
" /c
" After startup:
" -c

zsh+nvim(scoop)

echo &shell
" D:/msys64/usr/bin/zsh

echo &shellcmdflag
" /s /c

cmd+vim(msys2)

echo &shell
" C:\WINDOWS\system32\cmd.exe

echo &shellcmdflag
" /c

cmd+vim(scoop)

echo &shell
" C:\WINDOWS\system32\cmd.exe

echo &shellcmdflag
" /c

cmd+nvim(scoop)

echo &shell
" cmd.exe

echo &shellcmdflag
" /s /c

alanhamlett · 2022-01-07T17:39:22Z

I'm just worried about overwriting &shell for all Windows users, in case cmd.exe isn't in their path and we break things for someone.

Or override shellcmdflag?

Can't overwrite &shellcmdflag without also &shell because they're tied together:
https://vimhelp.org/options.txt.html#%27shell%27

moeshin · 2022-01-07T17:43:17Z

if &shell =~ 'sh\(.exe\)\?$'
    let &shellcmdflag = '-c'
endif

moeshin · 2022-01-07T18:17:28Z

if s:has_async
    if !s:IsWindows()
        let job_cmd = [&shell, &shellcmdflag, s:JoinArgs(cmd)]
    elseif &shell =~ 'sh\(.exe\)\?$' " or &shell !~ 'cmd\(.exe\)\?$'
        let job_cmd = [&shell, '-c', s:JoinArgs(cmd)]
    else
        let job_cmd = [&shell, &shellcmdflag] + cmd
    endif
elseif s:nvim_async
    if s:IsWindows()
        let job_cmd = cmd
    else
        let job_cmd = [&shell, &shellcmdflag, s:JoinArgs(cmd)]
    endif
endif

alanhamlett · 2022-01-07T18:20:28Z

That works for all variants?

moeshin · 2022-01-07T18:23:27Z

if &shell =~ 'sh\(.exe\)\?$'
    let &shellcmdflag = '-c'
endif

This way has bug in nvim.

:!ls .
" no work: zsh:1: command not found: ls .

:!'ls .'
" no work: zsh:1: command not found: 'ls .'

:!"ls ."
" work

moeshin · 2022-01-07T18:31:28Z

That works for all variants?

Yes

alanhamlett · 2022-01-07T19:10:27Z

That works for all variants?

Yes

With that change, do we still need to replace C:/ with /C/?

moeshin · 2022-01-07T19:18:14Z

Python msys still needs

> python3 -VV
Python 3.9.9 (main, Dec 28 2021, 11:05:23)
[GCC 11.2.0]

moeshin · 2022-01-07T19:21:47Z

Normal python does not need

> python3 -VV
Python 3.10.1 (tags/v3.10.1:2cd268a, Dec  6 2021, 19:10:37) [MSC v.1929 64 bit (AMD64)]

alanhamlett · 2022-01-07T19:22:55Z

Which of the variants from #122 (comment) or #122 (comment) are python msys?

moeshin · 2022-01-07T19:24:42Z

python doesn't affect these

moeshin · 2022-01-07T20:05:33Z

#122 (comment)
It's two problems:

execute command in vim or nivm. solve by Symlink require administrator on Windows #122 (comment)
python (install by pacman on msys2), the script path should unix-style. solve by Symlink require administrator on Windows #122 (comment) ?

a0daba9 does not completely solve the first problem. If I use git-bash etc.

alanhamlett · 2022-01-07T22:35:23Z

Fixed the first problem with a17a436.

Fixed the second problem with 441f5c7.

alanhamlett · 2022-01-08T07:29:18Z

Thanks again for your help fixing this!

moeshin · 2022-01-08T08:04:16Z

Thanks you.

a17a436 only fix job_start and jobstart.
There may also be a first problem with calling system() in nvim on bash, git-bash or zsh. #122 (comment)

echo &shell
" D:/msys64/usr/bin/zsh

echo &shellcmdflag
" /s /c

echo system('ls .')
" /usr/bin/bash: /s: No such file or directory

If overwrite let &shellcmdflag = '-c', there will be problems #122 (comment)

vim-wakatime/plugin/wakatime.vim

Line 771 in 441f5c7

echo "Today: " . s:Chomp(system(s:JoinArgs(cmd)))

In nvim, the type of cmd can be string or list.

let &shellcmdflag = '-c'

echo system('ls .') " no work

echo system(['ls', '.']) " work

function! g:System(cmd)
    " cmd is list
    let override = s:false
    if has('nvim')
        if has('win32') && &shell !~ 'cmd\(.exe\)\?$' && &shellcmdflag !~ '^\s*-'
            let override = s:true
            let _shellcmdflag = &shellcmdflag
            let &shellcmdflag = '-c'
        endif
    else
        let a:cmd = s:JoinArgs(a:cmd)
    endif
    let data = system(a:cmd)
    if override
        let &shellcmdflag = _shellcmdflag
    endif
    return data
endfunction

alanhamlett · 2022-01-09T06:13:12Z

Doesn't Nvim always have support for async? Then it would never reach system() on nvim... only on older Vim without async.

moeshin · 2022-01-09T08:29:30Z

ok

alanhamlett closed this as completed in f4a9cf8 Jan 6, 2022

alanhamlett reopened this Jan 6, 2022

alanhamlett closed this as completed Jan 8, 2022

Symlink require administrator on Windows #122

Symlink require administrator on Windows #122

Comments

moeshin commented Jan 6, 2022

moeshin commented Jan 6, 2022

alanhamlett commented Jan 6, 2022

moeshin commented Jan 6, 2022

moeshin commented Jan 6, 2022

alanhamlett commented Jan 6, 2022 • edited Loading

moeshin commented Jan 6, 2022

moeshin commented Jan 6, 2022

alanhamlett commented Jan 6, 2022 • edited Loading

moeshin commented Jan 6, 2022

alanhamlett commented Jan 6, 2022

alanhamlett commented Jan 6, 2022

moeshin commented Jan 6, 2022

alanhamlett commented Jan 6, 2022

moeshin commented Jan 6, 2022

alanhamlett commented Jan 6, 2022

moeshin commented Jan 6, 2022

alanhamlett commented Jan 6, 2022

moeshin commented Jan 6, 2022

moeshin commented Jan 6, 2022

alanhamlett commented Jan 6, 2022

moeshin commented Jan 6, 2022

alanhamlett commented Jan 6, 2022

moeshin commented Jan 6, 2022 • edited Loading

alanhamlett commented Jan 6, 2022

moeshin commented Jan 6, 2022

alanhamlett commented Jan 6, 2022

alanhamlett commented Jan 6, 2022

moeshin commented Jan 6, 2022

alanhamlett commented Jan 7, 2022

moeshin commented Jan 7, 2022

alanhamlett commented Jan 7, 2022

alanhamlett commented Jan 7, 2022

moeshin commented Jan 7, 2022

moeshin commented Jan 7, 2022 • edited Loading

alanhamlett commented Jan 7, 2022

alanhamlett commented Jan 7, 2022

moeshin commented Jan 7, 2022

moeshin commented Jan 7, 2022

moeshin commented Jan 7, 2022

moeshin commented Jan 7, 2022

alanhamlett commented Jan 7, 2022

moeshin commented Jan 7, 2022

moeshin commented Jan 7, 2022

alanhamlett commented Jan 7, 2022

moeshin commented Jan 7, 2022

moeshin commented Jan 7, 2022

alanhamlett commented Jan 7, 2022

moeshin commented Jan 7, 2022 • edited Loading

moeshin commented Jan 7, 2022 • edited Loading

alanhamlett commented Jan 7, 2022

moeshin commented Jan 7, 2022

moeshin commented Jan 7, 2022 • edited Loading

alanhamlett commented Jan 7, 2022

alanhamlett commented Jan 8, 2022

moeshin commented Jan 8, 2022

alanhamlett commented Jan 9, 2022

moeshin commented Jan 9, 2022

alanhamlett commented Jan 6, 2022 •

edited

Loading

alanhamlett commented Jan 6, 2022 •

edited

Loading

moeshin commented Jan 6, 2022 •

edited

Loading

moeshin commented Jan 7, 2022 •

edited

Loading

moeshin commented Jan 7, 2022 •

edited

Loading

moeshin commented Jan 7, 2022 •

edited

Loading

moeshin commented Jan 7, 2022 •

edited

Loading