Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A try to resolve the problem of COMException in DTE object #26

Merged
merged 2 commits into from
Jul 17, 2015

Conversation

gandarez
Copy link
Member

@gandarez gandarez commented Jul 2, 2015

@gandarez
Copy link
Member Author

gandarez commented Jul 2, 2015

@alanhamlett I decided to hold the solution name instead of trying to get it from DTE object every time. What do you think?

@@ -240,8 +256,11 @@ private static void SettingsPopup()

private static string GetProjectName()
{
var projectName = _objDte.Solution != null && !string.IsNullOrEmpty(_objDte.Solution.FullName) ? _objDte.Solution.FullName : null;
return !string.IsNullOrEmpty(projectName) ? Path.GetFileNameWithoutExtension(projectName) : null;
return !string.IsNullOrEmpty(_solutionName)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This nested ternary is a little confusing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not confusing lol. First try to get solution name if it's null then get from DTE object.

alanhamlett added a commit that referenced this pull request Jul 17, 2015
A try to resolve the problem of COMException in DTE object
@alanhamlett alanhamlett merged commit be5cce4 into wakatime:master Jul 17, 2015
@alanhamlett
Copy link
Member

Thank you! I'm testing this now and will release a new version to the gallery today.

@gandarez
Copy link
Member Author

Let's try it @alanhamlett

@pritianka-zz
Copy link

You guys are awesome; thanks for fixing VS - one of our most important
plugins!

Priyanka Sharma
Co-founder, WakaTime http://www.wakatime.com - Quantify your coding
www.twitter.com/pritianka
650-796-7125

On Fri, Jul 17, 2015 at 10:20 PM, Carlos Henrique Guardão Gandarez <
notifications@github.com> wrote:

Let's try it @alanhamlett https://github.com/alanhamlett


Reply to this email directly or view it on GitHub
#26 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants